Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for <link rel="canonical"> not compatible with dirhtml builder #122

Open
makhomed opened this issue Nov 3, 2017 · 0 comments
Open

Comments

@makhomed
Copy link

makhomed commented Nov 3, 2017

If I turn on canonical_url in config and use dirhtml builder, - Alabaster generates invalid urls.

url should be https://www.example.com/en/latest/tutorial/
but Alabaster generates https://www.example.com/en/latest/tutorial.html
and this is lead to 404 errors.

bug probably here: alabaster/layout.html

  {% if theme_canonical_url %}
    <link rel="canonical" href="{{ theme_canonical_url }}{{ pagename }}.html"/>
  {% endif %}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant