Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open RFP] ( $500 ) - Upgrade rendering tech to support reusing frame buffer for improvements to things like refraction #4

Open
br-matt opened this issue Nov 26, 2022 · 5 comments
Assignees

Comments

@br-matt
Copy link
Contributor

br-matt commented Nov 26, 2022

You will have to create a helper function to copy the current framebuffer into a texture (this will have to work in WebGPU too!).

In addition, a new class simplifying the copying of opaque objects should be designed. It will have to register on the RenderingGroup.onBeforeTransparentRendering observable to copy the current framebuffer into a texture that will be available to the user.

This class will probably need to be configured with some image processing post processes, as requested by the user (details will be discussed at implementation time).

To facilitate the use of this texture as a refraction texture for standard / PBR materials, you will add a global scene.refractionTexture property (in the same way we have scene.environmentTexture for the case of reflection) which will be used by default by the materials if no specific refraction texture has been defined at the material level.

A visualization test and according doc should be added to the framework.

@br-matt br-matt changed the title [Open Bounty] ($500) - Upgrade rendering tech to support reusing frame buffer for improvements to things like refraction [Open RFP] ($500) - Upgrade rendering tech to support reusing frame buffer for improvements to things like refraction Nov 26, 2022
@br-matt br-matt changed the title [Open RFP] ($500) - Upgrade rendering tech to support reusing frame buffer for improvements to things like refraction [Open RFP] ( $500 ) - Upgrade rendering tech to support reusing frame buffer for improvements to things like refraction Nov 26, 2022
@grimdeathr
Copy link

On this

@br-matt
Copy link
Contributor Author

br-matt commented Jan 30, 2023

Hey @grimdeathr thanks much for being the first !

I am going to mark this In Progress already. Once you have some idea, could you post your general thoughts. These RFP ones are more complicated items and it will be good to get @sebavan and other BJS folks thoughts on your general plan

@br-matt br-matt added In Progress Bounty In Progress and removed Unclaimed labels Jan 30, 2023
@grimdeathr grimdeathr removed their assignment Feb 12, 2023
@grimdeathr
Copy link

Requires quite a bit of time to deliver.

Instructions a bit unclear at first but cleared up once spoken to the BJS devs.

Thanks

@br-matt
Copy link
Contributor Author

br-matt commented Feb 16, 2023

Sounds good ! Thanks again.

Yes for anyone else reading, its a good idea to ask @sebavan and others from the BJS team here in comments for some clarification when taking these on and forming your general plan/questions.

@br-matt br-matt assigned br-matt and grimdeathr and unassigned br-matt Feb 16, 2023
@br-matt
Copy link
Contributor Author

br-matt commented Mar 21, 2023

Hey @grimdeathr just checking in on this. Are you still working on things ?

@br-matt br-matt added Unclaimed and removed In Progress Bounty In Progress labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants