Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change requests format #24

Closed
turbaszek opened this issue Apr 20, 2018 · 5 comments
Closed

Change requests format #24

turbaszek opened this issue Apr 20, 2018 · 5 comments
Labels
core

Comments

@turbaszek
Copy link
Member

Może ujednolicimy do
data?query
fill?query

?
@turbaszek turbaszek added the core label Apr 20, 2018
@glowacki-dev
Copy link
Collaborator

To znaczy? A jak teraz jest?

@turbaszek
Copy link
Member Author

Teraz jest
data/pair/timeframe?limit=100&untill=100000000
fill/pair?last=100000000

a proponowałbym
data?pair=BTCUSD&timeframe=1h&limit=100&untill=1000000
fill?pair=BTCUSD&last=1000000000

nie jest to jakaś straszna zmiana, raczej kosmetyka

@glowacki-dev
Copy link
Collaborator

Tak najbardziej prawilnie to będzie chyba coś takiego:

  • Pobieranie danych:
    GET /BTCUSD?timeframe=1h&limit=100&untill=10000000
  • Wypełnianie: 
    POST /fill

{
  pair: BTCUSD
  last: 10000000
}

@glowacki-dev
Copy link
Collaborator

Body z POST prawie na pewno będziesz czytał tak samo jak query, więc nie powinno to zrobić dużej różnicy

@turbaszek
Copy link
Member Author

Jest
GET /BTCUSD?timeframe=1h&limit=100&untill=10000000
POST /fill?pair=BTCUSD&last=10000000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glowacki-dev @turbaszek