Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change price and volume into indicators #44

Closed
glowacki-dev opened this issue Jun 24, 2018 · 3 comments
Closed

Change price and volume into indicators #44

glowacki-dev opened this issue Jun 24, 2018 · 3 comments

Comments

@glowacki-dev
Copy link
Collaborator

glowacki-dev commented Jun 24, 2018

We may unify API by only leaving dates array and indicators dictionary. This would require to change price and volume into indicators.

{
  dates: [...],
  indicators: {
    price: {
      info: [...],
      close: [...],
      high: [...],
      low: [...],
      open: [...]
    },
    volume: {
      info: [...],
      volume: [...]
    },
    BB: {
      info: [...],
      upperband: [...],
      lowerband: [...]
    },
    ...,
    sentiment: {
      info: [...]
    }
  }
}

This way each indicator will be a dictionary containing info array with tokens and some optional arrays with data used for drawing

@glowacki-dev
Copy link
Collaborator Author

Indicators after unification have been described in https://github.com/nuclearpinguin/Bitreport/wiki/Indicators

@glowacki-dev
Copy link
Collaborator Author

For fib levels we will lose information about fib percentage but it's not really that important right now

@turbaszek
Copy link
Member

Should we use the chart's type (uptrend etc.) as a sentiment for now?

@turbaszek turbaszek moved this from To do to In progress in MVP Jun 25, 2018
turbaszek pushed a commit that referenced this issue Jun 25, 2018
turbaszek pushed a commit that referenced this issue Jun 25, 2018
This reverts commit a16a591.
MVP automation moved this from In progress to Done Jun 25, 2018
turbaszek pushed a commit that referenced this issue Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
MVP
  
Done
Development

No branches or pull requests

2 participants