Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

NDK updated to r14b #50

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Conversation

koral--
Copy link
Contributor

@koral-- koral-- commented Mar 29, 2017

Changelog is also updated.
PS sdkmanager from SDK tools 25+ can also install NDK, but there is no way to specify exact version:

  lldb;2.3                          | 2.3.3614996  | LLDB 2.3                          | lldb/2.3/                        
  ndk-bundle                        | 14.1.3816874 | NDK                               | ndk-bundle/                      
  patcher;v1                        | 1            | SDK Patch Applier v1              | patcher/v1/   

There is no version number part (after semicolon) and the latest one from given channel (stable by default) is picked.
If it is acceptable to have dynamic version here I can send a new PR.

@viktorbenei
Copy link
Contributor

Perfect, thank you @koral-- !

Re:install from sdkmanager - we'll definitely discuss this, but would be interested in your opinion. Do you keep updating the NDK on your Mac/PC to the latest one, or do you use a specific version?

@viktorbenei viktorbenei merged commit 2b40e36 into bitrise-io:master Mar 29, 2017
@koral--
Copy link
Contributor Author

koral-- commented Mar 29, 2017

I generally keep updating and it is appropriate for most of my projects. However, in some cases, NDK is not backward compatible and I need to stick to the older version.
E.g. here is an issue android/ndk#314 introduced in r14. r13 and r15 (not released yet) is not affected. Haven't tried on r14b.
AFAIK that bug is reproducible in libwebp in this revision https://github.com/webmproject/libwebp/tree/16be192f4710fafe2f97687d929b00542d36bae2

@viktorbenei
Copy link
Contributor

Thanks for the info @koral-- , I think at least for now it's better to stick to the current, more explicit versioning solution, but we'll keep discussing this internally and we're alway open to feedback too! ;)

@pdefreitas
Copy link

@koral-- latest r14 bundled with android studio is still affected by android/ndk#314

@viktorbenei
Copy link
Contributor

What about r15?

@pdefreitas
Copy link

@viktorbenei idk, I'm using current google channels and they are distributing android studio 2.3.2 and ndk 14b

@koral--
Copy link
Contributor Author

koral-- commented May 23, 2017

Good to know.
Milestone for that issue android/ndk#314 is set to r15 so it seems that it does not need to be fixed in r14b. This may be an answer to android/ndk#314 (comment). They closed an issue because they commited a fix but version containing it is not yet released in the stable channel.

r15 is available in beta channel. You may add --channel=1 parameter to sdkmanager invocation to install it. Analogously it should be available through Android Studio.

@koral-- koral-- deleted the ndk-r14b branch May 23, 2017 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants