Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudKit support #118

Merged
merged 6 commits into from Aug 1, 2018
Merged

CloudKit support #118

merged 6 commits into from Aug 1, 2018

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Aug 1, 2018

No description provided.

BirmacherAkos
BirmacherAkos previously approved these changes Aug 1, 2018
Copy link
Contributor

@BirmacherAkos BirmacherAkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BirmacherAkos
BirmacherAkos previously approved these changes Aug 1, 2018
@godrei godrei merged commit bb50939 into master Aug 1, 2018
@godrei godrei deleted the cloudkit branch August 1, 2018 11:54
@leedsalex
Copy link

@godrei @BirmacherAkos This still doesn't work for us. We need to use the iCloudContainerEnvironment even though we don't use CloudKit, but because we use iCloud Documents.

@leedsalex
Copy link

Could you remove the logic around line 641 of main.go

usesCloudKit = sliceutil.IsStringInSlice("CloudKit", services)

Or change it to handle either CloudKit or CloudDocuments

@tamasbazs
Copy link

Hi @leedsalex,
Thanks for letting us know! I escalated this issue in our internal systems, our tooling team will look into what would be the best way to go and we will let you know here!

@godrei
Copy link
Contributor Author

godrei commented Aug 27, 2018

Hi @leedsalex ,
Thanks again for letting us know, the new pr: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants