Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: New tag #149

Closed
kroese opened this issue Nov 29, 2023 · 6 comments
Closed

Request: New tag #149

kroese opened this issue Nov 29, 2023 · 6 comments

Comments

@kroese
Copy link

kroese commented Nov 29, 2023

The last tag (0.15) is from March, but since then were several commits with fixes.

Is it possible to create a new tag (0.16) that is up to date with the master?

@bitromortac
Copy link
Owner

I have created a PR for the new grpc proto files for lnd 0.16.4 (the current files still work with lnd 0.16.X and 0.17.X). Will tag a new version once #151 is merged.

@bitromortac
Copy link
Owner

I would still like to add #152, using the readonly macaroon by default before tagging a new version. Would that break anything for you? This would affect openchannels and update-fees, for which a new macaroon has to be baked via a script.

@kroese
Copy link
Author

kroese commented Dec 31, 2023

@bitromortac I already baked the macaroon and update my compose file, so Im ready to go!

@kroese
Copy link
Author

kroese commented Jan 9, 2024

@bitromortac Can you create the tag? (My automatic build script depends on it) Thanks in advance..

@bitromortac
Copy link
Owner

Tag is pushed, sorry for the delay, I wanted to test things more.

@kroese
Copy link
Author

kroese commented Jan 9, 2024

Unfortunately it still doesnt work, I should not have used the word tag I guess.

Because what I needed was a release (as that creates a tag+branch for 0.16.0 and I can pull that branch), like you did with the previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants