Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Rewrite WM_NCHITTEST & WM_NCCALCSIZE handling. #139

Closed
wants to merge 8 commits into from
Closed

Windows: Rewrite WM_NCHITTEST & WM_NCCALCSIZE handling. #139

wants to merge 8 commits into from

Conversation

alexmercerind
Copy link

Windows 11

78LbgdC6sK

Windows 10

harmonoid_BGzL58HNri

Other changes:

abutcher-gh and others added 5 commits September 3, 2021 20:17
@abutcher-gh
windows: portability: Support Win7 and early Win10.
b823ae5
@alexmercerind
Update bitsdojo_window.cpp
7c1e6ad
@alexmercerind
Merge pull request #1 from abutcher-gh/windows-portability
bcec232 
windows: portability: Support Win7 and early Win10.
@alexmercerind
Linux: Remove enhanceFlutterView call while registering the plugin
32be835
@alexmercerind
Windows: Rewrite WM_NCCALCSIZE & WM_NCHITTEST handling
5e6ddd4 
- Use 0 MARGINS in DwmExtendFrameIntoClientArea
- Now resize hitbox lies outside the window frame.
- No window border is visible on Windows 10 or 11.
- Reference: melak47/BorderlessWindow#13
@alexmercerind
Copy link
Author

Hey @bitsdojo,

I know open source hasn't been much rewarding for all the hard-work. Unfortunately, I'm just a student so can't sponsor your work. Anyway, feel free to have a look/merge when you get time.

Best,
@alexmercerind

This was referenced Feb 18, 2022
Open
Open
@bitsdojo
Copy link
Owner

Hi @alexmercerind

Appreciate your message.

I've been offline in the past month and a half due to a medical issue but I will have access to my computer next week and I will take a look over the issues.

Bit

@ashutosh1211
Copy link

it still does not work on windows 7 SP1 64bit

image

@alexmercerind
Copy link
Author

it still does not work on windows 7 SP1 64bit

Thanks for the report. I will have a look & will require your feedback again.

@alexmercerind
Copy link
Author

alexmercerind commented Mar 5, 2022 •
edited

it still does not work on windows 7 SP1 64bit

image

@ashutosh1211 I can't seem to find any unsafe calls. Make sure you have the bitsdojo_window_windows registered like this (with dependency overrides) :

https://github.com/harmonoid/harmonoid/blob/b74a9d0ba8349334b990f023f44bab206069307f/pubspec.yaml#L70-L74

https://github.com/harmonoid/harmonoid/blob/b74a9d0ba8349334b990f023f44bab206069307f/pubspec.yaml#L83-L94

@ashutosh1211
Copy link

Thank you. It launches on windows 7 now without any error.

image

@alexmercerind alexmercerind mentioned this pull request Mar 27, 2022
Open
@jibbe
Copy link

jibbe commented Apr 6, 2022

@alexmercerind the window border seems to wider now, is this intended?

@alexmercerind
Copy link
Author

@alexmercerind the window border seems to wider now, is this intended?

On Windows 7 & 8.x it is. And there's no workaround if you want the "re-size area" to stay outside the window frame.

See Google Chrome on Windows 7 or 8.x, it will also have this border.

@alexmercerind alexmercerind mentioned this pull request May 1, 2022
Closed
This was referenced May 10, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListView not easy press and hold the mouse to scroll in edge
5 participants
@alexmercerind @bitsdojo @ashutosh1211 @jibbe @abutcher-gh