-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe difference to the official window_size plugin #17
Comments
On this topic, I recently got a pretty solid "universal" drag going, using the window_size plugin (which supports all 3 desktop platforms). This is some ugly code, and it's not quite perfect (dragging is not 1:1, more like 1:0.99), but it's really close:
Seems like there might be some opportunity to build on the base API's from WindowSize, and just add on what is really unique to this package (prefab'd Windows btns, maximize/minimize methods, and ability to hide native title bar). Though I think max/min probably best belong in the core as well, maybe we can try and land a PR for that. We had to remove BitDojo for now just cause it prevents us from building on Web, but luckily this works ok across all platforms. |
Haven't had the chance to test this on a non-retina screen but I guess you'd might want to do: _windowPos += d.delta * MediaQuery.of(context).devicePixelRatio; Related issue: flutter/flutter#71680 |
With regards to dragging, isn't the |
There is a (semi-) official plugin with very similar functionality at https://github.com/google/flutter-desktop-embedding/tree/master/plugins/window_size. It would be nice to describe what sets this plugin apart. Maybe the two could be merged?
The text was updated successfully, but these errors were encountered: