Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows to change an array of classes for the parameters of 'from' and 'to'. #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sejoalfaro
Copy link

hello, greetings and I hope you are well. I had the problem that I could only put one class and the solution I found is sending an array of classes.
Thank you!

src/iconate.js Outdated Show resolved Hide resolved
Copy link
Owner

@bitshadow bitshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheJoseScream for the PR. I have added feedback for minor change.

@sejoalfaro
Copy link
Author

Hi dear, I thought better of the solution, I think the ideal is to always send a string and be separated by spaces. I have already tried it and in my opinion it looks much better. I dont know if make a new pullrequest, I remain attentive to your response, thanks.

Copy link
Author

@sejoalfaro sejoalfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, I think the best way to do it is to send a string where each class is separated by a space and then grab that string and convert it into an array to go through it.

Copy link
Author

@sejoalfaro sejoalfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants