Implements Vec3A directly #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forwarding calls to Vec3 and having Vec3A wrap Vec3, this implements all the functions in Vec3A manually. This is required for SPRIR-V support because rust can't have repr(simd) on a type that isn't a collection of it's basic types.
Jasper-Bekkers
changed the title
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forwarding calls to Vec3 and having Vec3A wrap Vec3, this implements all the functions in Vec3A manually. This is required for SPRIR-V support because rust can't have repr(simd) on a type that isn't a collection of it's basic types.
This fixes the issue we found in #85 where Vec3A would accidentally not get the
repr(simd)applied to it, because it only got applied to the documentation type and not to the actual type we're using.