Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PathFinder math #3

Closed
kvark opened this issue Jul 11, 2019 · 2 comments
Closed

Include PathFinder math #3

kvark opened this issue Jul 11, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@kvark
Copy link

kvark commented Jul 11, 2019

https://github.com/servo/pathfinder/blob/71623eaab312ee0c33ba8ffa70954e166b564dfb/geometry/Cargo.toml

This one uses SIMD, but it could be more difficult to hook up. There is no mint support that I can see.

@bitshifter
Copy link
Owner

I had a quick look at adding this, currently on this branch https://github.com/bitshifter/mathbench-rs/tree/pathfinder.

I started with the Euler test and ran into issues because the pathfinder vector types don't support std::ops::AddAssign which seemed like fairly basic functionality and I didn't want to rewrite the benchmark to work around this.

Perhaps I should just open an issue asking for them to add it.

@bitshifter bitshifter added enhancement New feature or request help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jul 22, 2019
@bitshifter
Copy link
Owner

I've added benchmarks for pathfinder_geometry where it made sense. It's pretty minimal compared to the other libraries so I've left it as an optional library but I'll include it's results in the README next time I update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants