Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genesis_test.go file in nft module #209

Open
giorgionocera opened this issue Oct 2, 2022 · 2 comments
Open

genesis_test.go file in nft module #209

giorgionocera opened this issue Oct 2, 2022 · 2 comments
Labels
enhancement New feature or request low-priority NFT

Comments

@giorgionocera
Copy link
Contributor

In the nft module, there is the nft/types/genesis_test.go file, which should contain the tests for the genesis validation, including those for genesis file parsing.
These tests are missing ATM and we should implement them.
@ryusmo
Copy link
Contributor

ryusmo commented Oct 3, 2022

Here's the commit for genesis tests
b3d719a

Just have put genesis init and export functionalities on keeper, to follow latest Cosmos coding standard.

@giorgionocera
Copy link
Contributor Author

On that commit, it is also done what is asked in #156. Thank you!
The only thing I ask you is to improve the tests by also adding some other test examples, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low-priority NFT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giorgionocera @ryusmo