Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Authorization header is not urldecoded. #5

Closed
bittercoder opened this issue Aug 3, 2010 · 3 comments
Closed

OAuth Authorization header is not urldecoded. #5

bittercoder opened this issue Aug 3, 2010 · 3 comments

Comments

@bittercoder
Copy link
Owner

What steps will reproduce the problem?

  1. use oauth with header based authentication
  2. characters at the provider side are not urldecoded

What is the expected output? What do you see instead?
exception that the oauth_verifier is rejected, while the different is because of the missing decoding

What version of the product are you using? On what operating system?

Please provide any additional information below.
See the attachment which is a patch to fix this issue.

Reported by: http://code.google.com/u/avkekem/

Originally logged on google code here: http://code.google.com/p/devdefined-tools/issues/detail?id=9

A patch is included here:

http://devdefined-tools.googlecode.com/issues/attachment?aid=3384463087779190539&name=patchUrlDecode.diff&token=e904dc9ca8c8151ec20d109e214e4f33

@corneliutusnea
Copy link

Hi,
I think I've hit the same issue. When used Auth headers I always get rejection from the other party and I think it's the same encoding issue.
However the patch you attach does not seem to exist. Can anyone point me in the right direction on how to get this bug fixed?
Thanks,
Corneliu

@bittercoder
Copy link
Owner Author

That patch is here - I think google code has just changed the link:

http://code.google.com/p/devdefined-tools/issues/attachmentText?id=9&aid=3384463087779190539&name=patchUrlDecode.diff&token=831720cbd6d42e9c4afa9075c5fe8b37

I haven't had a chance to review it yet - but if you feel like implementing a patch and providing a pull request, be happy to apply it.

@bittercoder
Copy link
Owner Author

Closed, library no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants