Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Makefiles #44

Closed
ssuominengentoo opened this issue Feb 27, 2013 · 8 comments
Closed

Improved Makefiles #44

ssuominengentoo opened this issue Feb 27, 2013 · 8 comments

Comments

@ssuominengentoo
Copy link
Contributor

shared library, grab environment AR, CXX, *FLAGS, ..., all for packaging purposes so I can make the transmission p2p client use the system copy of libutp

would help a much if this was committed. grab the patch from here:

http://dev.gentoo.org/~ssuominen/libutp-Makefile.patch

@ghazel
Copy link
Contributor

ghazel commented Feb 27, 2013

Ugh, I loathe Makefiles.

Could you submit this as a Github pull request?

@ghazel
Copy link
Contributor

ghazel commented Feb 27, 2013

Oh, actually, what do you mean "system libtup"? libtup specifically says that is a bad idea. If a package manager has built libutp into a package they are asking for problems.

@ssuominengentoo
Copy link
Contributor Author

Asking for problems? I don't have a problem diffing internal copy of libutp within transmission source tree to the libutp tree from here and adjusting the system package accordingly.

I'll try to make push req. today

@ghazel
Copy link
Contributor

ghazel commented Feb 28, 2013

libutp is not considered stable enough to be included as a package in any package manager. It is designed to be compiled as part of your application.

@ssuominengentoo
Copy link
Contributor Author

What made me want to package libutp separately is this bug:

http://trac.transmissionbt.com/ticket/5002

So instead of updating the security bug in multiple packages embedding libutp, I'd prefer to just patch libutp and automatically solve the others through it
What a mess :/

@ghazel
Copy link
Contributor

ghazel commented Feb 28, 2013

That patch hasn't been applied to libutp yet. It's not a good idea to go patching all the apps with it, unless the developers test is specifically.

When libutp applies it, developers should test their app with the latest version of libutp.

@ssuominengentoo
Copy link
Contributor Author

OK then, I've removed the separately packaged libutp from Gentoo's CVS repository
The patch doesn't really make any difference anymore, and I suppose proper autotools or cmake patch would be preferred anyways, so I'll just close this
Thanks for clarification (it's what I was afraid of)

@ghazel
Copy link
Contributor

ghazel commented Feb 28, 2013

Most preferred would be a setsockopt to allow applications to use the LEDBAT congestion controller with TCP instead of an application-level UDP transport to begin with ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants