Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Commands (hotkeys) #7

Closed
UberPanda opened this issue Oct 7, 2016 · 27 comments
Closed

Keyboard Commands (hotkeys) #7

UberPanda opened this issue Oct 7, 2016 · 27 comments

Comments

@UberPanda
Copy link

Either I missed it or the current state of completion in chrome extension is only through mouse based interaction.
I do not think I am the only one thinking that keyboard based interaction would be nice too.

@kspearrin
Copy link
Member

Good suggestion,

How would you expect the hotkeys to work? I am not a huge hotkey user myself as far as browser usage is concerned, so I may not be the best to define this feature.

One option could be with the browser omnibox API. https://developer.chrome.com/extensions/omnibox

@UberPanda
Copy link
Author

My current habit (which comes from using keepassx) would be something like :

Type a key combination (ctrl + shift + n in my case) which prompts available completions, navigate through them with arrows and select one with enter.
Hotkeys could also be used to create a new entry.
Thus, I do not think that omnibox would be a good solution. However the commands api should do the trick : https://developer.chrome.com/extensions/commands

@kspearrin kspearrin changed the title Completion keyboard shortcut Keyboard Commands Oct 8, 2016
@kspearrin
Copy link
Member

kspearrin commented Oct 8, 2016

Excellent. I'll put this on the roadmap for an upcoming release.

In the meantime if anyone has an opinion on what these hotkey command combinations should be, I'll definitely take that into consideration.

@kspearrin
Copy link
Member

kspearrin commented Oct 8, 2016

Check out 691d262

Now it's as simple as Ctrl+Shift+Y, tab through your available logins for the website in the current tab, and press enter to autofill.

Also added a hotkey to generate a random password to your clipboard.

@kspearrin kspearrin changed the title Keyboard Commands Keyboard Commands (hotkeys) Oct 8, 2016
@UberPanda
Copy link
Author

Seems nice for now.
Next step would be being able to customize hotkeys, but that looks like quite a bit more work.

@kspearrin
Copy link
Member

The hotkeys are fully customizable via the browser extension settings. These are just the defaults.

@UberPanda
Copy link
Author

Indeed, seems to work fine. Might need a little visual refinement though (currently I can only see which login is selected through a very thin blue highlight, more explicit highlighting might be a plus).

@kspearrin
Copy link
Member

Yea, it just needs some additional styling for the focus state. Will see what I can do.

@blockloop
Copy link

I have a manually configured LastPass keyboard shortcut which I can set in the options.

@kspearrin
Copy link
Member

This should help: 97fe375

@blockloop
Copy link

@kspearrin when will this make it to the Chrome store?

@kspearrin
Copy link
Member

@blockloop it's there now with 1.1.0 (might take ~30 minutes or so to propagate) https://github.com/bitwarden/browser/releases/tag/v1.1.0

@UberPanda
Copy link
Author

UberPanda commented Oct 11, 2016

Just noticed that if you use the addon, you would get something like :

  • shortcut
  • Tab(s)
  • Enter (that fills the login)
  • What should happen : enter which actually logs you in

But then pressing enter would not do anything. A simple way to solve this would be setting the text cursor to be at the end of the filled password. Another way would be to include the enter in the plugin after typing the password (as keepass would do by default).

@blockloop
Copy link

blockloop commented Oct 11, 2016

I've updated and restarted Chrome and I'm still not able to use the keyboard shortcuts. I don't even see that command as an option in the shortcuts menu. I'm on OSX if that somehow matters.

image

image

@kspearrin
Copy link
Member

@blockloop You don't see what command? I see both supported commands there now. "Activate the extension" is the one that will open the extension to the "Current Tab" page.

It appears the that default that I picked for OSX (Command+Shift+Y) is already taken by something else in the browser and therefore loses that binding. This is why you are seeing "Not set". You can choose to set it to whatever you like.

If you can, please recommend me a good default for OSX since it seems the one I have chosen cant work there.

@blockloop
Copy link

blockloop commented Oct 12, 2016

Ah. I was looking for a command to "fill form." I misunderstood. I used CTRL \ (backslash) with LastPass. I don't think it had any issues.

EDIT: looks like the only thing I could find that wasn't conflicting was ALT Comma. I used ALT G for generating a secure password (stole that from LastPass)

@SylwesterZarebski
Copy link

What about Firefox - how can I change shortcut?

@kspearrin
Copy link
Member

@SylwesterZarebski Unfortunately Firefox does not allow you to change the shortcut at this time.

@SylwesterZarebski
Copy link

Thanks, that's sad, but i'll wait for new version which allows to change key shortcut (like LastPass or other addons).

@kspearrin
Copy link
Member

You'll find that the new version of lastpass for Firefox coming out soon will also lose this functionality. This all has to do with the move to web extensions which is not as feature rich for Firefox yet as the older Firefox apis.

@shkm
Copy link

shkm commented Jul 22, 2017

Great that we have a shortcut, but two requests below. I use Firefox.

  1. I have to hit tab twice to get to my list of logins, which isn't ideal.
  2. If there's only one login available, can it just autofill when pressing the shortcut?

@ermsdev
Copy link

ermsdev commented Feb 2, 2020

Would it be possible to do something like Alfred for Mac OS where results are numbered? For instance, pressing Cmd+3 selects the 3rd option. If browsers don't allow extensions to assign their own shortcuts, then could there be user assignable shortcuts for each of the first few matching items?

Screen Shot 2020-02-01 at 8 32 53 PM

@KevinNSTA
Copy link

@stephenermshar this is a pretty old request, probably should just make a feature request here https://community.bitwarden.com/c/feature-requests

They Migrated away from Issues as Feature Requests a while back - like a couple years I think

@shkm
Copy link

shkm commented Feb 6, 2020

@akaleeroy
Copy link

So Bitwarden doesn't have Omnibox API integration? What's the "power-user" login sequence presently?

For example LastPass on Chromium:

  1. Alt+D to go to address bar
  2. lp Spacebar to select the LastPass extension's search engine
  3. Type acmeforums
  4. to select ACME Inc. Forums from suggestions
  5. Enter

@PsychoData
Copy link

PsychoData commented Apr 18, 2020

It is reprogrammable with Chrome. You can check what you have it set to under chrome://extensions/shortcuts
For example I use both 1 Password X (Chrome) at - Ctrl-Shift-X
and I have BitWarden customized to Ctrl-Shift-S

But I believe the default for BitWarden (By clearing my choices) is Ctrl-Shift-Y
image

@1024mb
Copy link

1024mb commented Apr 25, 2020

At least in Vivaldi I had to enter chrome://extensions/shortcuts to assign the shortcut because there was none by default, this was caused most probably by Tab Session Manager which also used the same shortcut to (de)activate the extension.
Couldn't this shortcut configuration be implemented inside Bitwarden's extension settings?

addisonbeck pushed a commit that referenced this issue May 5, 2022
Add signing gh (ignoring the macos build because I don't have those things)
Hinton pushed a commit that referenced this issue May 25, 2022
* Update invocations of inquirer.js prompts to output prompt to stderr.

fixes #7

* Updates to use updated typings from @types/inquirer
Hinton pushed a commit that referenced this issue May 25, 2022
…#15)

* Update invocations of inquirer.js prompts to output prompt to stderr.

fixes #7

* Updates to use updated typings from @types/inquirer

* Removes extraneous async / await from writeLn
Hinton pushed a commit that referenced this issue Jun 3, 2022
* Add sequentialize to prevent parralel loading of cipher keys

Massively improves start up performance of extensions

* Add tests for sequentialize

* Fix sequentialize as it was caching calls for all instances together

* Add sequentialize to the functions that have internal caches

* Adding sequentialize to getOrgKeys makes big performance difference

* Update cipher.service.ts

* Update collection.service.ts

* Update folder.service.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants