Update manifest to fully support FF 66 keyboard shortcut manager

[setyb]

manifest.json currently contains a blank description for the keyboard shortcut to open bitwarden in the sidebar. This causes confusion in the new FF 66 keyboard shortcut manager.

I can submit a pull request to fix this, or you can do it, whichever you prefer.

[kspearrin]

What kind of confusion? I am not sure why it is blank to begin with. Maybe we should remove it like _execute_browser_action? Does the browser provide a description for those special commands in Firefox like on Chrome?

[setyb]

What kind of confusion? I am not sure why it is blank to begin with. Maybe we should remove it like _execute_browser_action? Does the browser provide a description for those special commands in Firefox like on Chrome?

Here is how it currently looks in Firefox:

I'm working on the fix now, and will have it done soon.

[setyb]

I fixed the missing string, replaced a default string with a custom string, removed non-standard periods, and improved the ordering.

(And to avoid an inevitable future pending conflict, I incremented the version string.)

I hope this helps! :)

[jay-dee7]

Would we be ever able to add custom shortcuts to specific credentials? as in there's a few websites i have to login daily, it would be a great addition i think. If it's already a thing, please let me know/ I couldn't find anything so far

[setyb]

@jay-dee7 That's an interesting idea. To my knowledge, it's not currently possible.

[cscharf]

@setyb , sorry just saw this from the recent conversation/update. Can we close this particular issue based on your resolution of the manifest earlier?

[setyb]

@cscharf Good question. I think 2 things maybe need to occur:

1. Perhaps move the suggestion by @jay-dee7 to another issue so it doesn't get lost.
2. See if my code resolving this issue made its way into the release. I did not sign the CLA (see Implement a fair and bilateral Contributor Agreement or remove it completely server#1115).

[bitwarden-bot]

Hi @setyb,
We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it.
Thanks!