Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed]Login on paypal.com broken on Firefox #982

Closed
LeGiTiM opened this issue Jul 26, 2019 · 67 comments
Closed

[Fixed]Login on paypal.com broken on Firefox #982

LeGiTiM opened this issue Jul 26, 2019 · 67 comments
Assignees

Comments

@LeGiTiM
Copy link

LeGiTiM commented Jul 26, 2019

The bug has been resolved and the fix is integrated into the extension.

Hi there!

Edit: the developer fixed this bug in the code, but it's still in the process of the next release of bitwarden. We must be patient until it's out.
I added the way to skirt the bug in "Actions to skirt the bug"

Description of the bug:
When attempting to log in on paypal.com, bitwarden can fill the email, then when hitting "next", the page returns an error "Entrez le code CAPTCHA correct." (English: "Enter the correct CAPTCHA code"). [There is no visible captcha, it's a hidden procedure of the website, it always worked without captcha for the user before the bug]. Paypal refuses to go further, it's thus impossible to enter the password, and log in successfully.
(Moreover: side minor bug: the "Auto-fill feature on page load" doesn't work on paypal.com. I guess it's related to the high security standards and unsual login method, I don't care if this bug is not resolved: hitting the keyboard shortcut or the extension click-fill feature both work).

Actions that skirt the bug:

  • manually type the email with the keyboard (then you can make bitwarden autofill the password).
  • disable the bitwarden extension
  • being logged out/locked (vault closed) beforehand

Tweak that doesn't do anything:

  • disable "Enable Auto-fill On Page Load" (I thought this was the reason at first, that's why I tested it first).

Versions of Firefox tested:

  • Nightly (70.0a1)
  • Firefox regular ( 68.0.1)
    (I'm sorry, I don't know exactly since when (or which version) this bug is there, i'd say a couple of months?)

Operating System:
Windows 10 v. 1903.

Exclusions:

  • no bug on Chromium-variant browsers
  • not this bug on Microsoft Edge.

Thank you in advance for looking into it!

@kspearrin
Copy link
Member

I am not able to reproduce. When I go to paypal.com to login in, I see email and password on the same page/form. Is this not what you see?

image

@taylorsilva
Copy link

taylorsilva commented Jul 27, 2019

Came here to report this bug as well. I'm using Firefox 69.0b7 with macOS.

@kspearrin I think @LeGiTiM is seeing this login screen which gives me the captcha issue as he's described:

Screen Shot 2019-07-27 at 12 35 02 PM

and here's the error you get when using bitwarden to fill the email field:
Screen Shot 2019-07-27 at 12 39 29 PM
If I manually type in my email I don't get this error.

If you open the paypal login page while in incognito mode you'll get the above screen (or clear all paypal cookies).

After logging in and out I now see the same screen that you see and autofill works.

Screen Shot 2019-07-27 at 12 36 26 PM

@LeGiTiM
Copy link
Author

LeGiTiM commented Aug 1, 2019

Indeed, it's just as @taylorsilva explained. It happens only for a "clean visit" of the website.
Bitwarden is probably filling the password field in the background, and clicking "Next" somehow triggers the final login step, while the catcha validation is supposed to happen when you click "next", before you enter the password => error message.
I don't know if you can fix this bug since it seems more related to the site method itself, than the fault of bitwarden.
But maybe that trying to detect sites who use 2 steps logins like this and injecting the username, then the password only after clicking "next" would be useful (or an otion to define this behavior manually for a site, or an option to disable autofill on a site)? I know that Tumblr and Yahoo use a similar method (with a next button before entering the password), but I didn't get issues with bitwarden on them.

@taylorsilva
Copy link

taylorsilva commented Aug 2, 2019

Is there a way that bitwarden can only fill in fields that are visible on the screen? Just throwing the obvious idea out there, I'm sure "visible" is a tough state to define if the site is not explicitly using type=hidden.

EDIT
Looked at the paypal page and they use a css class called "hide" which just does a display: none.

@Christilut
Copy link

Came here to report the same problem.

Happens when I go to paypal.com and I'm not already logged in. I press CTRL-SHIFT-L and Enter and I get the captcha error message.

Firefox 68

@c3l3si4n
Copy link

I was here to talk about the same problem
hope this is fixed :)

@kah0922
Copy link

kah0922 commented Aug 28, 2019

I can confirm that I also suffer from this issues on the latest Firefox Nightly.

@SharkyRawr
Copy link

This is still an issue when using Bitwarden auto-fill. :/

@kspearrin
Copy link
Member

Should be fixed next version.

@taylorsilva
Copy link

Thanks @kspearrin! I'm guessing this was the fix?
c994032

@kspearrin
Copy link
Member

Yes.

@hrcl
Copy link

hrcl commented Sep 17, 2019

@kspearrin Thank you for this fix. When will this get into a new release?

@truthsword
Copy link

truthsword commented Sep 22, 2019

Similar issue w/Edge Chrome (dev). Instead of captcha, we see "Try entering the code again."

I'm using the extension "From Microsoft Store".

@targodan
Copy link

(Still) having the same issue on Firefox 69.0.1 64bit on ArchLinux. This is quite bad as PayPal is quite an essential website.

Any ETA on the release?

@sorryusernameisalreadytaken

I think it is possible to fix this by adding the fields:
login_email
&
login_password

Can anybody proof this?
See my attachment.
bitwarden_paypal_addon_problem

But it seems to be important to disable "Enable Auto-fill On Page Load". Otherwise some functions did not work anymore, like adding an amount to payout to your bank account.

@Hammerfest
Copy link

Hammerfest commented Oct 8, 2019

"Try entering the code again."

Same issue for me, been about 2 months, I just turned off autofill for paypal so that's good enough, manually typing out works fine. Now I search for it as I was annoyed this evening and look, a bug report!

Glad to see it should be fixed when the next update is released!

Thanks again for the great addon! Bitwarden (itself and the addon) Well worth the yearly I more then happily subscribe to!

@LaurentOngaro
Copy link

LaurentOngaro commented Nov 6, 2019

Same issue with vivaldi and chrome browsers with bitwarden extension installed
The solution is to open paypal in a private window (as it, bitwarden is disabled) and paypal will valid its captcha

@mathsen
Copy link

mathsen commented Nov 12, 2019

Same issue with Firefox and Bitwarden. In private mode it works - I didn't suspect bitwarden and found this issue by accident. Please fix this.

@Tryer101
Copy link

Same here, latest Firefox and Bitwarden.

Glad I came across this thread.

@Gamertech
Copy link

Got this today on Firefox 70.0.1

@LeGiTiM
Copy link
Author

LeGiTiM commented Nov 23, 2019

I'm not very familiar with github, I don't know if/how I can 'reopen' this thread as an active issue. I'm afraid that the contributors/developers of bitwarden don't see/watch this one anymore. Apparently @kspearrin has done something to fix it (thank you!), but it hasn't worked, given all the reports here (still not working as intended for me either).
I suggest newcomers with the same bug to open a new thread with description of the issue and eventually a link to this one, to just make sure they realize it's still bugged.
Have a good day everyone!

@Tryer101
Copy link

@LeGiTiM :)

I contacted Bitwarden via the official website earlier this morning with a Ref. to this thread.
I understand the Dev knows about this bug/problem but it's still occurring after many months.
Could this be due to the fact that this software is developed and maintained by only one person?
I'm contemplating the idea of switching to another password manager at this point.

@LeGiTiM
Copy link
Author

LeGiTiM commented Nov 23, 2019

It's true that it's annoying (especially for people who care about their privacy and wipe their cookies & local data between sessions), but it's a very specific bug to how paypal handle logins, more than the very own fault of Bitwarden's developer. I guess time is needed to find the accurate trick to get around procedures like this.
It'd be a shame to get rid of bitwarden just for this annoyance, especially when we can still login by entering manually the email with our keyboard to skirt the bug.
The problem is that this bug will affect all users of bitwarden with a fresh install of firefox, or after a cleaning of cookies/local storage, and they won't know the trick above, so reports will keep coming, or some people, who don't know the tip and won't have the reflex/patience to seek for a solution, will really ditch bitwarden because they will assume they can't login to such an essential site as paypal.
I'm sure a developer will find the solution for this at some point.
Edit: it appears there was a little confusion. The fix has already been coded and merged in the source code, but it's not yet implemented in the current version running in our browsers. That's why we still have the issue. We just have to be patient and wait for the next public release of bitwarden. Thanks again kspearrin!!!

@Tryer101
Copy link

Good point! :)

One thing though, I wonder why Bitwarden's Dev don't send an email to all users so the seeking for a solution wouldn't have to be. At this age of communication, such a task is very easy to do.

@sorryusernameisalreadytaken

@kspearrin Thank for the fix. Can you estimate when we can calculate with an rls?

@Hammerfest
Copy link

Last browser release was Jul 30, has apparently been fixed for a while, but no release date mentioned sooooooo

We sit, we wait, my paltry renewal occurred and I am still ok with that.

@mathsen
Copy link

mathsen commented Nov 26, 2019

I really can't understand why such an important fix doesn't get released for the masses... I mean even if it means just cherry-picking this single commit and release a hotfix for the current version. This bug probably affects much more people than those who are registered on github, search for it (it is a closed bug report...) and comment here. Many people might even not even consider, that it's bitwarden's fault (as me for a couple of time). So please release this overdue fix.

@sorryusernameisalreadytaken

build and install it on our own, as described in the README (which failed for me for unknown reasons, but YMMV)

Can you explain your "unknown reasons" a bit more?

@setyb
Copy link
Contributor

setyb commented Dec 24, 2019

So... why is it not rolled out on the add-on store yet? Oversight? Limitations from the store?

There is currently no release built since July 30 2019 in https://github.com/bitwarden/browser/releases . The fix was implemented after that date.
Thus, and it's just my guess based on the above, I doubt the code with the fix has been sent to the extension repositories yet.

@setyb
Copy link
Contributor

setyb commented Jan 5, 2020

Update: Version 1.42.2 has been built, which includes this fix. According to Kyle, it's been sent to Mozilla, so now it's up to them to approve it and make it available. Even if it gets approved right away, Firefox 72 will be released on the 7th of January, so bitwarden v1.42.2 will either be released before then, or be held until at least the 9th of January, because IIRC extension updates are disabled for a day (or two) during Firefox releases to reduce the possibility of compounded problems.

@LeGiTiM
Copy link
Author

LeGiTiM commented Jan 5, 2020

Thank you for the info @setyb !

@setyb
Copy link
Contributor

setyb commented Jan 5, 2020

Thank you for the info @setyb !

You're welcome. My pleasure.

@truthsword
Copy link

Hopefully, v1.42.2 has come to Firefox already, but Chrome still awaits the update.

@Tryer101
Copy link

Tryer101 commented Jan 21, 2020 via email

@setyb
Copy link
Contributor

setyb commented Feb 10, 2020

@LeGiTiM You may want to update the original post now that the fix has been released and confirmed to work.

@LeGiTiM
Copy link
Author

LeGiTiM commented Feb 10, 2020

The ticket is closed, I think it's sufficient.
But I edited anyway for people who dig too deep ^^

@LeGiTiM LeGiTiM changed the title Login on paypal.com broken on Firefox [Fixed]Login on paypal.com broken on Firefox Feb 10, 2020
addisonbeck pushed a commit that referenced this issue May 5, 2022
@bpsib
Copy link

bpsib commented Jul 26, 2023

This problem has now resurfaced yet support can't seem to be able to reproduce it.

@brettjenkins
Copy link

Getting this myself this past week

@Mavarius1989
Copy link

indeed. Just added TOTP for Paypal and had the error.

@thetic
Copy link

thetic commented Aug 5, 2023

this is affecting me, too

@MrPistachios
Copy link

Im getting this issue constantly

@Nibestase
Copy link

Nibestase commented Aug 13, 2023

Same for me :-(
Issue on a Win11 Pro 64, Firefox 115.0.3 (64 bits), Bitwarde extension 2023.7.1, and same with Edge 115.0.1901.203 (64 bits)
When Bitwareden extension is disabled, typing manually email, password and OTP works fine.

image

image

image

@SVNKoch
Copy link

SVNKoch commented Aug 20, 2023

Can confirm, getting the same error.
@kspearrin could you consider reopening this ticket please?

@dlorde
Copy link

dlorde commented Aug 20, 2023

Yup, I'm getting this autofill error on PayPal too - but if I copy/paste the password, it's OK.

@bpsib
Copy link

bpsib commented Aug 20, 2023

A workaround I found that works is to remove the Authenticator key from the PayPal Bitwarden item and have it in a separate item entry. I can then use the PayPal item for username and password to autofill then the PayPal authenticator key separate item for copy and pasting the TOTP verification code.

I really think there should be an option in Bitwarden to turn off attempted TOTP auto-filling in certain items to avoid problems like this in the future.

@cagonzalezcs
Copy link
Contributor

@bpsib

That idea is certainly something I can bring up with the team.

With that in mind, this issue presents in a similar manner to #5880 and has been resolved with the merge of PR #5700 . The changes from that PR are set to release with v2023.8.

The closing comment on #5880 provides more context on why the issue existed and how it was fixed.

@ackstorm23
Copy link

This is not fixed, or you have additional bugs causing teh same problem. This is still happening for me and results in me having to use a different browser without Bitwarden to make ANY paypal purchases.

@bpsib
Copy link

bpsib commented Aug 26, 2023

@ackstorm23 It was broken again by v2023.7.0 and has since been fixed again by v2023.8.2 which should soon come through as an update.

@barthermans
Copy link

@cagonzalezcs any idea when v2023.8 will become available in the Firefox extensions store?

@cagonzalezcs
Copy link
Contributor

cagonzalezcs commented Sep 8, 2023

@barthermans

The update should be rolling out fairly soon, though we did recently have some issues arise with regards to submission of the extension on Firefox.

Our devops team made some improvements to simplify and optimize the extension bundle submission process to the various web extension storefronts. Unfortunately, a small issue with how that build process was compiling the source files caused a delay for the release.

That said, we worked out the issues yesterday and have resubmitted the extension to the Firefox storefront. I apologize for the inconvenience.

@alator21
Copy link

This is still happening on chrome on ubuntu (Version 121.0.6167.85 (Official Build) (64-bit))

@cagonzalezcs
Copy link
Contributor

@alator21

A fix for this should be coming out in the upcoming extension release. This comment provides more context - #5915 (comment)

@jprusik jprusik self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests