Add support for biometrics to Safari #1775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Adds support for browser biometrics to Safari. It was previously omitted due to needing some special logic to function correctly and we still used the old app extension.
Biometrics in Safari works slightly differently in that they do not require the desktop companion app to be running. (It's still necessary to enable biometrics inside the desktop app)
Code Changes
supportsBiometrics
.Testing Considerations
We need to test the biometrics on Safari on machines without TouchId (should fail with
no support
error), on machines with biometrics disabled in desktop app. With biometrics enabled, and lastly logging out of desktop and logging into another account (should fail with wrong user error). We should also do some quick regression testing on other browsers to ensure nothing broke.