Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button can navigate to lock page without vault being locked #1882

Closed
dario-piotrowicz opened this issue Jun 6, 2021 · 2 comments · Fixed by #1883
Closed

Back button can navigate to lock page without vault being locked #1882

dario-piotrowicz opened this issue Jun 6, 2021 · 2 comments · Fixed by #1883

Comments

@dario-piotrowicz
Copy link

dario-piotrowicz commented Jun 6, 2021

Describe the Bug

When unlocking the extension you can press your mouse's back button and go back to a seemingly locked vault, but if you press your mouse's forward button you'll go back to the unlocked vault.

Not a big deal but this behaviour looks a bit strange

Steps To Reproduce

  1. Open the extension
  2. Provide you master password to unlock your vault
  3. Press your mouse's back button, you'll be redirected to the previous panel and vault will look locked
  4. Press your mouse's forward button, you'll be back into your vault (without having entered the master password)

Expected Result

The mouse back button should not redirect you to the panel asking you for your master password

Actual Result

You get redirected to the panel asking you for your master password, but you can still go back to your vault without providing the password (even though a message on the panel says that your vault is locked)

Screenshots or Videos

bitwarden browser

Environment

  • Operating system: Ubuntu 20.04.2 LTS
  • Browser: Chromium Version 91.0.4472.77 (Official Build) snap (64-bit)
  • Build Version: Version: 1.50.0

Additional Context

This does not happen in Firefox, there the mouse back button doesn't redirect you to the master password panel

The mouse events are button 8 press and 9 press for back and forward respectively

If you close the extension and reopen it the back button does not redirect you to the master password panel (basically it happens only after you've just accessed your vault without closing the extension)

At some point this issue was also present in the desktop version but I believe it is not longer there (bitwarden/desktop#314)

@eliykat
Copy link
Member

eliykat commented Jun 6, 2021

I fixed this in web vault and desktop (bitwarden/desktop#847), clearly browser also needs the same fix. Thanks for the report!

@dario-piotrowicz
Copy link
Author

cool, my please :)

By the way I just tested it in Chromium and Firefox and the latter strangely doesn't seem to have the issue so it may be a bit edge case

@eliykat eliykat changed the title Mistakable behaviour when using the mouse back button Back button can navigate to lock page without vault being locked Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants