Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default match detection no longer works for IPV6 URIs #2107

Closed
tangowithfoxtrot opened this issue Oct 8, 2021 · 5 comments · Fixed by #3168
Closed

Default match detection no longer works for IPV6 URIs #2107

tangowithfoxtrot opened this issue Oct 8, 2021 · 5 comments · Fixed by #3168
Labels
browser Browser Extension bug

Comments

@tangowithfoxtrot
Copy link
Contributor

tangowithfoxtrot commented Oct 8, 2021

Steps To Reproduce

  1. Save an IPV6 URI using the default match detection. I'm using Quad9's IPV6 DNS address: https://[2620:fe::fe]/.
  2. Use the “Launch” button or manually navigate to the URL.
  3. Notice that the Bitwarden extension does not detect the URI match.

Expected Result

The extension detects the URL using the default match detection.

Actual Result

The extension does not detect the URL.

Additional Context

The last version that default URI matching with IPV6 works for is 1.51.1.

Using regex matching works if you escape the slashes and brackets: https:\/\/\[2620:fe::fe\]\/.

Operating System

macOS

Operating System Version

11.6

Web Browser

Firefox

Browser Version

92.0.1

Build Version

1.52.0 and 1.53.0

@fakuivan
Copy link

fakuivan commented Mar 7, 2022

Any updates on this? Is there anything I can do to help?

@Hinton Hinton added the browser Browser Extension label May 5, 2022
@ggiesen
Copy link

ggiesen commented Jul 6, 2022

Also running into Bitwarden's match detection not matching IPv6 literals. Tried both with brackets around and without.

@dbosompem
Copy link

Hi @ggiesen, the team will make time and look into this issue. Thanks for bringing this up.

@fakuivan
Copy link

I have tried the workaround mentioned by @tangowithfoxtrot but it doesn't seem to work on Android.

This is with version 2022.6.1 (4795)

@djsmith85
Copy link
Contributor

@fakuivan Just wanted to clarify that this issue and my linked PR addresses the web, desktop and browser extension. With the browser extension (also FF on Android) fix having the biggest impact. If the issue occurs on a mobile client (native Android/IOS) with/without the workaround mentioned by @tangowithfoxtrot then please open an issue at our mobile repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants