Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwarden Breaks Keycloak's Webauthn Support #7141

Closed
1 task done
abueide opened this issue Dec 8, 2023 · 10 comments · Fixed by #6799
Closed
1 task done

Bitwarden Breaks Keycloak's Webauthn Support #7141

abueide opened this issue Dec 8, 2023 · 10 comments · Fixed by #6799
Labels
browser Browser Extension bug

Comments

@abueide
Copy link

abueide commented Dec 8, 2023

Steps To Reproduce

  1. Setup keycloak as an idp
  2. Enable webauthn in one of your authentication / registration flows
  3. Try to register a key with & without the bitwarden extension installed. Without, it works fine. With bitwarden extension you get this error:

image

Expected Result

Able to register passkeys via keycloak's webauthn api when using keycloak as an idp

Actual Result

Get an error

Security key registration result is invalid.
TypeError: Cannot read properties of undefined (reading 'authenticatorAttachment')

Screenshots or Videos

image

Additional Context

No response

Operating System

Windows, Linux

Operating System Version

No response

Web Browser

Chrome, Firefox, Brave

Browser Version

No response

Build Version

2023.10.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@abueide abueide added browser Browser Extension bug labels Dec 8, 2023
@NovaSilentium
Copy link

Hello there!

I was able to reproduce this issue myself, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@trmartin4
Copy link
Member

Hi @abueide! We have addressed this problem in #6799, which is scheduled to be in our next release of the browser extension.

@abueide
Copy link
Author

abueide commented Dec 8, 2023

Hi @abueide! We have addressed this problem in #6799, which is scheduled to be in our next release of the browser extension.

Awesome thanks for the update

@oxytu
Copy link

oxytu commented Dec 13, 2023

@djsmith85 @trmartin4 sorry, this issue is not resolved with release 2023.12. Still happens for my Keycloak instance with the same error as initially reported.

@agross
Copy link

agross commented Dec 14, 2023

@oxytu Confirmed to be broken with 2023.12.0 here, too.

@beposec
Copy link

beposec commented Dec 24, 2023

@trmartin4 thanks for your work. But as the others say, its still broken. Can you try to reproduce this again?

@oxytu
Copy link

oxytu commented Dec 26, 2023

@djsmith85 merry christmas, first of all. Have you noticed the other comments above? The issue is still closed.

@oxytu
Copy link

oxytu commented Dec 27, 2023

@agross @beposec "Workaround" I found: just set a value for Authentication Attachment in your Keycloak Realm / Authentication settings / Webauthn.

Best regards

@agross
Copy link

agross commented Dec 27, 2023

@oxytu Thank you, it seems to be working with this setting. I set <Realm> | Authentication | Policies | Webauthn Passwordless Policy | Authenticator attachment to Cross platform and the Bitwarden dialog popped up during the registration process.

@djsmith85
Copy link
Contributor

@djsmith85 merry christmas, first of all. Have you noticed the other comments above? The issue is still closed.

@oxytu Merry Christmas to you too. Changes from #6799 are going to be included in the 2024.1-release scheduled for mid next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants