Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Modifier characters (e.g. accents) in Master Password are not parsed when text is hidden #128

Closed
SamuAlfageme opened this issue Aug 28, 2018 · 6 comments

Comments

@SamuAlfageme
Copy link

I have a Spanish keyboard layout and thus, I use modifier characters (e.g. "ACCENT ACUTE": ´ + A = Á) in my master password to add even more entropy and avoid brute force attacks.

When keeping the password hidden, these modifier characters do not parse from keyboard at all - i.e. only the next key pressed goes in the password. However, If you "Toogle Visibility" and type the same, it does work:

@kspearrin
Copy link
Member

Weird. Is there a problem when trying to do the same when logging into the web vault?

@SamuAlfageme
Copy link
Author

@kspearrin interesting enough, I checked with Firefox 61.0.2 and it worked. Switched to Chrome 68.0.3440 and failed miserably.

I'm guessing this is an upstream issue in electron/chromium with Angular2's input (https://github.com/bitwarden/web/blob/1873ce41b6f2a94baca8b6dac396adf7ce1a7a13/src/app/accounts/login.component.html#L15-L16). Since the only thing that changes in the DOM when toggling the visibility is input's type from password to text. Shall I move the issue to bitwarden/web?

@kspearrin
Copy link
Member

No need to move it. Sounds like a n issue with Chromium in general so I am not sure if there is anything we can do about it. Have you tried looking for the problem on chromium's bug reports board?

@SamuAlfageme
Copy link
Author

Actually; It seems to be unrelated to Angular but rather macOS (cocoa) + chromium/webkit bug. Ref:

... I remember seeing something similar happening on onePassword's menubar dropdown

@kspearrin
Copy link
Member

Thanks for finding those. I am going to close this since it is an upstream issue. At least you have a workaround.

@SamuAlfageme
Copy link
Author

SamuAlfageme commented Nov 18, 2019

@kspearrin happy to announce this one has already been fixed in Chromium and therefore on the Bitwarden client. Tested with Version 1.16.6:

🎉 ref. https://bugs.chromium.org/p/chromium/issues/detail?id=78048#c24 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants