Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

#a11y: Lack of clearly visible focus indication for some interface components #1332

Closed
patrickhlauke opened this issue Feb 13, 2022 · 5 comments · Fixed by #1514
Closed

#a11y: Lack of clearly visible focus indication for some interface components #1332

patrickhlauke opened this issue Feb 13, 2022 · 5 comments · Fixed by #1514
Labels
accessibility Accessibility concern or compatibility with assistive technologies. bug

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Open Bitwarden
  2. Use Tab / Shift+Tab to navigate using the keyboard

Expected Result

A visible keyboard focus indication on the "My Vault" and "Send" controls.

Actual Result

While there does appear to be a subtle shift in background colour, there's no clear indication which one has focus (compare with other elements that have a reasonably clear indicator)

Screenshots or Videos

Animated GIF of navigating through the application - note that after the "No folder" focus goes to "My Vault", then "Send", but there really isn't much of a visual indication.
bitwarden-desktop-focus-indication

Additional Context

No response

Operating System

Windows

Operating System Version

10

Installation method

Direct Download (from bitwarden.com)

Build Version

Version 1.31.2 Shell 16.0.7 Renderer 96.0.4664.110 Node 16.9.1 Architecture x64

@Hinton
Copy link
Member

Hinton commented Feb 14, 2022

Hi @patrickhlauke,

Thanks for reporting this. If I understand it correctly it's primarily the My Vault and Send tabs in the bottom left corner that are missing focus styling? The Test Identity seems to also lack the top border as it's obstructed by the search bar.

@Hinton Hinton added the accessibility Accessibility concern or compatibility with assistive technologies. label Feb 14, 2022
@patrickhlauke
Copy link
Contributor Author

yes, primarily the My Vault and Send since they pretty much lack any discernible/clear focus indication. the Test Identity (and well, all items really) could do with a proper full outline (not just the little sliver at the top) if feasible, but at least they arguably have something visible already there (with the subtle change in colour and the left-hand border changing)

@squarepupil
Copy link

I will also note that I only discovered this issue because the UI behavior recently changed when hitting tab after entering a search query. It used to jump the cursor to the list of search results and now (frustratingly) jumps the cursor to the account selection dropdown followed by the menu on the left side of the application, which can be seen in the gif at the top of this issue report.

As a by-the-way, does anyone know how to quickly get to your first search result without having to touch the mouse?

@patrickhlauke
Copy link
Contributor Author

patrickhlauke commented Feb 15, 2022

@squarepupil this will likely be one of those "squaring the circle" type problems. for some folks the old focus order will make sense, for others the current one (and it will likely depend on their actitivity/intent - if they did do a search, then I could imagine them wanting to get right to the results, but then again maybe they want to filter out/hone in on results specific to a particular type or folder as well). i think the only way around that would be to start treating the different areas/panels in the app as separate regions that you jump between using something like F6 (standard at least on Windows, can't remember offhand if macOS and Linux have a similar key)

@patrickhlauke
Copy link
Contributor Author

x-ref #1325

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Accessibility concern or compatibility with assistive technologies. bug
Projects
None yet
3 participants