Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

macOS Vault Master Password Entry Holds Secure Keyboard Input Open #298

Closed
mwegner opened this issue Aug 15, 2019 · 14 comments · Fixed by #970
Closed

macOS Vault Master Password Entry Holds Secure Keyboard Input Open #298

mwegner opened this issue Aug 15, 2019 · 14 comments · Fixed by #970

Comments

@mwegner
Copy link

mwegner commented Aug 15, 2019

With the macOS Desktop Vault, version 1.15.2, I'm seeing some new behavior with secure keyboard input or keyboard focus. I'm on Mojave 10.14.6.

My issue is that Bitwarden keeps keyboard focus active in the Master Password field, even when it's in the background. When secure keyboard input is active, system-wide keyboard macro software is unable to function (in my case, Keyboard Maestro).

This is a recent break for me, but I'm not sure if secure keyboard input is new, or focus behavior has changed. As near as I can tell, here's what's happening:

  • When Bitwarden loses application focus, it ends the secure input/keyboard focus on the password field

  • When Bitwarden regains application focus, it puts keyboard focus back on the field (if it had it when you left; if you click off the master password field to stop keyboard focus, it won't return it when application focus returns)

This is all fine!

But: It takes a few seconds for Bitwarden to go from application start to fully initialized, where it renders the vault locked UI. If it loses application focus during this window, it still begins with keyboard focus in the master password entry, and thus secure input, even though it's no longer the front application.

The way my applications start up on boot, by the time Bitwarden has fully initialized, some other restarting application has taken focus. I have to tab in and out of Bitwarden, or manually click off the master password entry text field, before Keyboard Maestro begins working.

I think that adding a check to see if Bitwarden is still the front-most application before putting keyboard focus into the password field will fix this.

@kspearrin
Copy link
Member

The recent update upgraded our version of Electron, so maybe something internally changed there. We don't do any checks to see if Bitwarden is the foregrounded applications, so I would need to look into Electron APIs to see if that is possible to detect.

@mtgto
Copy link
Contributor

mtgto commented Mar 1, 2021

Good news. You can now use Secure Keyboard Input by Electron v10 or later.
https://github.com/electron/electron/blob/v10.0.0/docs/api/app.md#appissecurekeyboardentryenabled-macos

@joejoinerr
Copy link

+1 for implementing this! It's playing havoc with my KM macros and text expansion. I thought it was a macOS issue but found that whenever I quit Bitwarden I never have the issue.

@danmandle
Copy link

This is still an ongoing issue. There is another issue here: #738

@eliykat
Copy link
Member

eliykat commented Jun 27, 2021

There are several issues reporting the same problem with different apps. I'm going to close all the other threads and use this as the main issue. However I'll link them here for reference:

@Dasymi
Copy link

Dasymi commented Aug 7, 2021

I've got the same issue with Bitwarden preventing text expansion by Alfred. Is there any update on this?

@eliykat
Copy link
Member

eliykat commented Aug 9, 2021

Hi @Dasymi, this bug should be fixed by upgrading to the latest version of Bitwarden desktop (v 1.27.1). I used Alfred when troubleshooting this bug and testing the fix. If you're still experiencing this bug after upgrading, please post here with more info about how to reproduce.

EDIT: I forgot that I missed the last release window for this bugfix. It'll be included in the upcoming release, v. 1.28.0, which you can tentatively expect later this month.

@xeroxoid
Copy link

xeroxoid commented Sep 9, 2021

Hi @eliykat. I see v1.28.2 has been released a couple of weeks ago. Every when are new versions released to the Mac App Store?

I am still on v1.27.1 (531) via the App Store just because I am using the unlock with biometrics for Chrome Extension functionality which as I understand is only available with Bitwarden through the App Store.

@eliykat
Copy link
Member

eliykat commented Sep 9, 2021

Hi @xeroxoid, we submit our releases to the app store at the same time they are released on our website, however the approval process with Apple can take a few weeks. If it's been 2 weeks already then hopefully it's not too far away. I've checked with the team and there may have been some delay here - we're following it up now.

@eliykat
Copy link
Member

eliykat commented Sep 16, 2021

@xeroxoid, v1.28.2 is now live on the Mac App Store.

@xeroxoid
Copy link

TY for the update!

@escobar5
Copy link

I'm running v1.28.3 and still having problems with Alfred Text Expansion

@eliykat
Copy link
Member

eliykat commented Oct 12, 2021

Hi @escobar5, can you please:

  1. describe what problem you're having
  2. provide step-by-step instructions on how to reproduce the problem

@escobar5
Copy link

Hi @eliykat, sorry for my vague comment.

I'm having trouble replicating it, it seems to only happens at times, contrary to previous versions where definitely having bitwarden desktop open will disable alfred text expansion. It seems it might have something to do with unlocking browser extension with touch id.

I will try to provide you with more details when it happens to me again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants