Android/iOS: Accessibility - show/hide password toggle buttons don't programmatically expose their state

[patrickhlauke]

Steps To Reproduce

1. Turn on TalkBack
2. Go to a screen with an "eye" show/hide password toggle button
3. Set focus to it - it announces as "Toggle visibility, Button" (A)
4. Double-tap to activate the button (B)
5. Leave the button, then return to it (C)

Expected Result

(A) When first focusing on the button, it should give a hint about its current state (that it's currently disabled / visibility is off).
(B) Toggling the button should dynamically announce its state changed
(C) Returning to the button, it should now announce that it's on (visibility is on / the button is enabled/pressed/active)

Actual Result

The button conveys no state information. Toggling the button does not lead to any TalkBack hint/announcement that anything actually happened

Screenshots or Videos

Photos (as can't take on-device screenshots, since Bitwarden suppresses this) of Bitwarden on Android, with TalkBack's speech output visible at the bottom:

Additional Context

The desktop client and extension had similar issues, until I addressed them - see bitwarden/clients#2228 and bitwarden/desktop#1442

For android native, there's likely a native "toggle" type button/attribute that can be set on buttons. its value should be dynamically changed to reflect its current state.

Failing that, a dynamic change of accessible name ("Toggle visibility, on" or "Toggle visibility, pressed" / "Toggle visibility, off" or "Toggle visibility, not pressed") would do the trick. Just something that conveys what's going on to assistive technology users.

Operating System

Android

Operating System Version

11

Device

Motorola moto g(8)

Build Version

2.18.0 (4572)

Beta

• Using a pre-release version of the application.

[patrickhlauke]

Same is true on iOS