PS-1174 - Allowing to search items with diacritics #2269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs has a match on search
fedemkr
requested changes
Dec 28, 2022
Comment on lines
+179
to
+199
| private string RemoveDiacritics(string text) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(text)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| string formD = text.Normalize(NormalizationForm.FormD); | ||
| StringBuilder sb = new StringBuilder(); | ||
|
|
||
| foreach (char ch in formD) | ||
| { | ||
| UnicodeCategory uc = CharUnicodeInfo.GetUnicodeCategory(ch); | ||
| if (uc != UnicodeCategory.NonSpacingMark) | ||
| { | ||
| sb.Append(ch); | ||
| } | ||
| } | ||
|
|
||
| return sb.ToString().Normalize(NormalizationForm.FormC); | ||
| } |
There was a problem hiding this comment.
IMO this should be an extension method of String. It's easier to find it afterwards and to reuse if needed in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Items with diacritics should be returned on searches that match their name or subtitles without diacritics
Code changes
Added a method to remove diacritics from a string and validated if the cipher item name and subtitle matches the search
Screenshots
Android
iOS
Before you submit
dotnet format --verify-no-changes) (required)