Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting Notes field in 'view login' mode. #50

Closed
sreich mannequin opened this issue Feb 21, 2017 · 7 comments
Closed

Allow selecting Notes field in 'view login' mode. #50

sreich mannequin opened this issue Feb 21, 2017 · 7 comments
Labels
bug Something isn't working

Comments

@sreich
Copy link
Mannequin

sreich mannequin commented Feb 21, 2017

Currently the Notes field in a login behaves oddly, at least on Android. Touching the text field highlights the field but won't let you select any text. For that you have to go to edit mode. It should allow you to select text but in a read only mode.

@kspearrin kspearrin mannequin added the bug Something isn't working label Feb 21, 2017
@kspearrin
Copy link
Mannequin

kspearrin mannequin commented Feb 21, 2017

It uses a standard Xamarin Label so I'm not sure why you cant select it for copy. Will have to investigate.

@ghost
Copy link

ghost commented Mar 29, 2017

TextIsSelectable is by default false on Android TextView
Also, I don't think it's a good idea to enable text selection on a Label, gives unnecessary selection while trying to scroll.

@kspearrin
Copy link
Mannequin

kspearrin mannequin commented Apr 20, 2017

I added a copy when tapped function in the next release. Is this sufficient?

https://github.com/bitwarden/mobile-maui/commit/952935de23678cb65c571cfb913cf2edd5682526

@sreich
Copy link
Mannequin Author

sreich mannequin commented Apr 21, 2017

It won't allow me to copy individual words, would it?

In my password manager I have security questions(randomized, because questions are insecure) and other important stuff, as well as previous passwords, stored in the notes, these things are often complex or randomized, etc so I'd need to be able to copy them individually.

@kspearrin
Copy link
Mannequin

kspearrin mannequin commented Apr 21, 2017

I am a little leery to enable the TextIsSelectable option mentioned above that @Shan11812 mentioned. I'll have to test it out more.

@sreich
Copy link
Mannequin Author

sreich mannequin commented Apr 21, 2017

I hear you, but I know that lastpass handles this just fine with the behavior I described. Admittedly I should use custom fields, but those aren't trivial to add in any password manager on a per site basis and they seem to be inflexible in general.

@kspearrin
Copy link
Mannequin

kspearrin mannequin commented Mar 9, 2018

We are moving away from tracking Bitwarden feature requests like this one as GitHub issues. We have created a Bitwarden Community Forum which has a section for submitting, voting for, and discussing product feature requests.

Please sign up on our forums, search to see if this request already exists. If so, you can vote for it and contribute to any discussions about it. If not, you can re-create the request there so that it can be properly tracked.

This issue will now be closed. Thanks!

@kspearrin kspearrin mannequin closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant