Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 8 & Swift 3.0 compatibility #52

Closed
SaifAlDilaimi opened this issue Jun 24, 2016 · 23 comments
Closed

Xcode 8 & Swift 3.0 compatibility #52

SaifAlDilaimi opened this issue Jun 24, 2016 · 23 comments

Comments

@SaifAlDilaimi
Copy link

hey guys,

I would like to know if theres a status or any workaround to use this pod with xcode 8.. I'm getting errors as soon it converts to swift 3.0..

@SaifAlDilaimi
Copy link
Author

no idea??

@bizz84
Copy link
Owner

bizz84 commented Jun 26, 2016

Xcode 8 is currently beta software.

My current plan for Swift 3 support is as follows:

  • towards August I will create a parallel Swift 3 branch.
  • once Xcode 8 reaches GM or official release status, I will switch this branch to master and the old master to a Swift 2 branch as to keep compatibility for users still on Xcode 7

pull requests for the Swift3 branch are welcome, in case anyone wants to migrate sooner

@SaifAlDilaimi
Copy link
Author

Did u tried whats need to be done? I would like to help but I'm not sure how to start... If you could hint me where to start I may help...

@SaifAlDilaimi
Copy link
Author

any way to use this pod with xcode 8???

@bizz84
Copy link
Owner

bizz84 commented Jul 2, 2016

The first step would be to clone the repo, then load the project with Xcode 8 and perform the code migration to Swift 3.
As I'm not planning to add support for this just yet, you could fork this project, make the changes as described and use this as a submodule.

@SaifAlDilaimi
Copy link
Author

SaifAlDilaimi commented Jul 3, 2016

Okay thanks, but what do you mean making the changes as described and use this as a submodule?

Also as far as I know Xcode 8 Supports Swift 2.x. Would that be a option?

@bizz84
Copy link
Owner

bizz84 commented Jul 4, 2016

@deada92 I would follow these steps:

  • (optional) Fork this repository, so that you can make changes on your own version
  • Clone the repository
  • Open the project in Xcode 8
  • Xcode should suggest migration to Swift 2.3 or 3.0. Choose either
  • Compile. If there are any errors, fix them
  • Commit your changes and push them to your repository

As you can't publish a new pod version as you don't own this repository, it's probably easiest if you make the changes on your copy and import the project as a submodule in your app.

@SaifAlDilaimi
Copy link
Author

thanks @bizz84 !

I already fixed a lot of issues but I'm stucked at the covention of switch cases. I don't see anything wrong but I get error when I use this commit: SaifAlDilaimi@fa18537

Can you look over it & give me a hint?

@bizz84
Copy link
Owner

bizz84 commented Jul 11, 2016

@deada92 sorry haven't had the chance to further look into this. Hopefully I can start the port to Swift 3 over the coming weeks.

@SaifAlDilaimi
Copy link
Author

SaifAlDilaimi commented Jul 15, 2016

Any idea what could be the issue??

@bizz84
Copy link
Owner

bizz84 commented Jul 22, 2016

@deada92 sorry for the late answer. I have now added Swift 3.0 support on this branch. This has been tested to compile on Xcode 8 beta 3.

Please note that while this compiles, I have not yet tested if all the APIs work as expected.

@bizz84 bizz84 changed the title xcode 8 & swift 3.0 status xcode 8 & swift 3.0 status [here](https://github.com/bizz84/SwiftyStoreKit/tree/swift-3.0) Jul 22, 2016
@bizz84 bizz84 changed the title xcode 8 & swift 3.0 status [here](https://github.com/bizz84/SwiftyStoreKit/tree/swift-3.0) xcode 8 & swift 3.0 status - https://github.com/bizz84/SwiftyStoreKit/tree/swift-3.0 Jul 22, 2016
@bizz84 bizz84 changed the title xcode 8 & swift 3.0 status - https://github.com/bizz84/SwiftyStoreKit/tree/swift-3.0 Xcode 8 & Swift 3.0 compatibility Jul 22, 2016
@felixLam
Copy link
Contributor

Hi all, I have added PR for Beta 6: #69

@InnaLMC
Copy link

InnaLMC commented Sep 12, 2016

hi, branch swift-3.0 gets errors for xcode 8 gm, could you please update it?

@bizz84
Copy link
Owner

bizz84 commented Sep 13, 2016

Updated and merged into master:
#82
I should be able to publish the new pod version shortly.

@androidcn
Copy link

merge to master,branch?

@bizz84
Copy link
Owner

bizz84 commented Sep 15, 2016

Yes, master branch now is for Xcode 8 / Swift 3.

I'm currently having issues with publishing a new pod version as pod lib lint fails since I migrated to Xcode 8. Until this is resolved you can install SwiftyStoreKit as a submodule or with Carthage

@androidcn
Copy link

i. will Waiting for you
Andrea Bizzotto notifications@github.com于2016年9月16日 周五上午5:11写道:

Yes, master branch now is for Xcode 8 / Swift 3.

I'm currently having issues with publishing a new pod version as pod lib
lint fails since I migrated to Xcode 8. Until this is resolved you can
install SwiftyStoreKit as a submodule or with Carthage


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQlY7EXldkO6KaRB1K0k4tThJrn1AMiks5qqbRxgaJpZM4I-HMS
.

能蟹仔

@bizz84
Copy link
Owner

bizz84 commented Sep 16, 2016

Pod version 0.5.1 is now published. IF you're using cocoapods, run pod update to update SwiftyStoreKit to Xcode 8

@alexbilbie
Copy link

alexbilbie commented Sep 19, 2016

@bizz84 I'm still getting the following error with 0.5.1 and the Xcode 8 GM:

“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

screen shot 2016-09-19 at 20 33 53

I've tried this too pod 'SwiftyStoreKit', :git => 'https://github.com/bizz84/SwiftyStoreKit.git', :branch => 'master' and get the same error

@alexbilbie
Copy link

A quick update on my comment above; I let Xcode run the Swift 3 upgrade tool and despite not finding any code to change it has resolved my problem of being able to use the project.

@androidcn
Copy link

Update latest CocoaPods
Alex Bilbie notifications@github.com于2016年9月20日 周二上午6:11写道:

A quick update on my comment above; I let Xcode run the Swift 3 upgrade
tool and despite not finding any code to change it has resolved my problem
of being able to use the project.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQlY_oj0JDM3rmo8a9wVDOpS6gI9_Dsks5qrwiOgaJpZM4I-HMS
.

能蟹仔

@bizz84
Copy link
Owner

bizz84 commented Oct 19, 2016

@alexbilbie Still having issues with this or can I close the issue?

@alexbilbie
Copy link

Please feel free to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants