Does not work for third level domains

[ojurkiewicz]

Example:
extractDomain('https://www.argos.co.uk/');

Expected result:
argos.co.uk
Current result:
co.uk

Possible solution:
Check against some good TLD list. For example: https://publicsuffix.org/list/public_suffix_list.dat

[bjarneo]

Hi. Thanks for the issue. One does already exist, can be found at #1.

I've though about what you mentioned, but that will increase the size for this library drastically. However, one thought is to create a separate lib to support both.

[ojurkiewicz]

So sorry, should've read that before posting. It will increase the size (but i would argue if drastically 😉) but as far as i'm concerned this is the only way to get 100% accurate results.

[bjarneo]

No need for sorry :)

Regarding the size, this file is 215K large 😄: https://publicsuffix.org/list/public_suffix_list.dat

Could of course do some magic to fetch only when needed

[sadortun]

@bjarneo You could also strip the file down as part of the build process and reduce it to a nested array. where the top level indices match TLD names ex: {"ac": { 'com', ' 'edu','gov' }}

[madeindjs]

I think you could use psl librairy. The minified size is "only" 127kb.

[bjarneo]

@madeindjs I caved in and used the psl lib. Here are the details: #7