fix: Load new state from session/local storage when available after a silent renew

[Powersource]

Fixes #361

...I think. When I edited directly in node_modules (it complained when i npm linked because of duplicate react) it worked but this code is slightly different.

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

[Powersource]

Would love some help on why those tests are failing

[Powersource]

Ok managed to test locally now and seems to work :)

[simenandre]

Did you manage to get them fixed? The build seems to fail, maybe you can add your fix? :)

[Powersource]

No I don't have a fix for the CI stuff. My local fix was to build the package and then remove the node_modules so when I npm linked npm wouldn't get confused about the react versions. Might take a look at the CI stuff though.

[codecov]

Codecov Report

Merging #363 (09a0bf8) into master (a6edfff) will decrease coverage by 3.77%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##            master     #363      +/-   ##
===========================================
- Coverage   100.00%   96.22%   -3.78%     
===========================================
  Files            1        1              
  Lines           47       53       +6     
  Branches        11       11              
===========================================
+ Hits            47       51       +4     
- Misses           0        2       +2     

Impacted Files	Coverage Δ
src/AuthContext.tsx	96.22% <66.66%> (-3.78%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6edfff...e4aa5b2. Read the comment docs.

[Powersource]

Basically just needed to update the tests so that also UserManager.events also is mocked.

[Powersource]

Anything I can help with to help get this merged?

[ryancole]

I don't think the UserManager is supposed to change, which would mean a React Effect on it wouldn't really make sense to me.

If there is an issue with the underlying oidc-client library not refreshing tokens, then perhaps this would be better as an issue on the repo for that client? That library is what handles the refreshing, as far as I can tell.

[Powersource]

@ryancole

1. Does it maybe make sense to still have the Effect to still have the removeUserLoaded if/when the AuthProvider stops being rendered but maybe due to the way an app's code is structured the UserManager object still survives?

2. The problem isn't that oidc-client fails to refresh. It does that correctly. The problem is that this library doesn't reload the refreshed state into the userData state hook.

[ryancole]

@Powersource Ah, OK I see now. You're right. The user data state needs to be updated when oidc-client refreshes it. That effect looks fine to me, but perhaps the dependency on userManager is not needed? Perhaps just an empty dependency array so that it sets up the event handler on first load?

In the scenario in which we use this library, our AuthProvider is at the top of our React component tree and persists through the lifetime of the app. Our UserManager never changes.

In your scenario, is UserManager changing over time?

[Powersource]

Removed userManager from the dep array now :)

[ryancole]

Looks good to me. /cc @cobraz

[github-actions]

🎉 This PR is included in version 1.1.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Powersource]

Thanks!