fix: state update on an unmounted component #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run |
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 95.00% 95.31% +0.31%
==========================================
Files 1 1
Lines 60 64 +4
Branches 13 15 +2
==========================================
+ Hits 57 61 +4
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
simenandre
approved these changes
Mar 9, 2021
Comment on lines
+96
to
+100
| useEffect(() => { | ||
| return () => { | ||
| isMountedRef.current = false; | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| return () => { | |
| isMountedRef.current = false; | |
| }; | |
| }, []); | |
| useEffect(() => () => { | |
| isMountedRef.current = false; | |
| }, []); |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
## [1.2.1](v1.2.0...v1.2.1) (2021-03-09) ### Bug Fixes * state update on an unmounted component ([#522](#522)) ([0e873f4](0e873f4))
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mancioshell
pushed a commit
to mancioshell/oidc-react
that referenced
this pull request
Mar 20, 2021
mancioshell
pushed a commit
to mancioshell/oidc-react
that referenced
this pull request
Mar 20, 2021
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.