Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add silentRedirectUri option. #528

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

pseudoramble
Copy link
Contributor

Adding another prop for the UserManager so a custom one isn't required for specifying this.

Thanks for looking over all these and also for the work on the project in general!

@update-docs
Copy link

update-docs bot commented Mar 10, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #528 (10c467c) into master (9e6b3fb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           1        1              
  Lines          65       66       +1     
  Branches       16       17       +1     
==========================================
+ Hits           62       63       +1     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/AuthContext.tsx 95.45% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6b3fb...cc036e3. Read the comment docs.

Copy link
Member

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing 🎉

This looks good!

@simenandre simenandre merged commit a349d4d into bjerkio:master Mar 15, 2021
github-actions bot pushed a commit that referenced this pull request Mar 15, 2021
# [1.4.0](v1.3.0...v1.4.0) (2021-03-15)

### Features

* Add silentRedirectUri option. ([#528](#528)) ([a349d4d](a349d4d))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants