Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDOM.render is no longer supported in React 18. Use createRoot instead. #862

Closed
simenandre opened this issue Jul 15, 2022 · 3 comments · Fixed by #945
Closed

ReactDOM.render is no longer supported in React 18. Use createRoot instead. #862

simenandre opened this issue Jul 15, 2022 · 3 comments · Fixed by #945

Comments

@simenandre
Copy link
Member

Tests are warning us that we are using a deprecated feature. It can be seen in this build:
https://github.com/bjerkio/oidc-react/runs/7359386639?check_suite_focus=true

The full warning is this:

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Seems like we have a few references to this in our tests, so if anyone wants to open a pull request fixing that it would be awesome!

@Ebukachuqz
Copy link

Ebukachuqz commented Jul 20, 2022

so if anyone wants to open a pull request fixing that it would be awesome!

I would love to do that.
However , I can't seem to find the file where ReactDOM.render is called. Can you help me out please.

@simenandre
Copy link
Member Author

If you open the step (collapsible) named Run yarn test, there should be some more details there.

PS: Currently on my mobile phone, so I couldn't verify 😅

@jamesdh jamesdh linked a pull request Mar 1, 2023 that will close this issue
@jamesdh
Copy link
Contributor

jamesdh commented Mar 1, 2023

Fixed by #945

@jamesdh jamesdh closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants