You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In line with the print-uart and print-rtt features, perhaps a print-defmt would make sense?
I am happy to submit a PR for this, however I have a question. The current implementation calls several println!() functions. In most defmt log printers, the contents of the log statement gets printed along with the location in the source code that the log statement was called.
Would this mean that we would have only one error!() invocation in the panic_handler? Or should we still call error!() each time we call println().
Also, due to this quirk of defmt vs println style printing, should I add this functionality to esp-println? Because it may be a mismatch of expected output format.
The text was updated successfully, but these errors were encountered:
I'm not too familiar with defmt to be honest. Probably error!() is more like dbg! from the std-lib, then?
Sounds like you probably only want one invocation of error! in your implementation
By "should I add this functionality to esp-println" you mean printing the source code location?
No, I meant should I add a print-defmt feature to esp-println. I'm not sure if its a good match because defmt introduces its own formatting by attaching line numbers and log levels to each print. See this example:
In line with the
print-uart
andprint-rtt
features, perhaps aprint-defmt
would make sense?I am happy to submit a PR for this, however I have a question. The current implementation calls several
println!()
functions. In most defmt log printers, the contents of the log statement gets printed along with the location in the source code that the log statement was called.Would this mean that we would have only one
error!()
invocation in the panic_handler? Or should we still callerror!()
each time we callprintln()
.Also, due to this quirk of defmt vs println style printing, should I add this functionality to
esp-println
? Because it may be a mismatch of expected output format.The text was updated successfully, but these errors were encountered: