New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary unsafe #2

Closed

MabezDev opened this issue Aug 23, 2022 · 2 comments

Member

MabezDev commented Aug 23, 2022

https://github.com/bjoernQ/esp-serial-dbg/blob/93c9e7f31a49e50eb36e686d90080a372afda338/esp-serial-dbg/src/riscv.rs#L8 can just be static, the Mutex & RefCell will take care of getting a safe mutable reference :)

Collaborator

bjoernQ commented Aug 23, 2022

Good catch! Will address this while changing the code to use the shiny new cs-mutex
Thanks for pointing this out

Collaborator

bjoernQ commented Aug 23, 2022

Fixed now + using critical-section - good we have that cs-implementation now

bjoernQ closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment