Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Collection of Image" ext. Tileset with TSX and images in different subfolders only shows empty map #1081

Closed
LearnCocos2D opened this issue Sep 13, 2015 · 4 comments
Labels
bug Broken behavior.
Milestone

Comments

@LearnCocos2D
Copy link

It seems Tiled 0.13 is no longer able to find "collection of images" tiles if

  • the tileset is an external TSX located in a subfolder relative to the TMX file
  • the image files are in a different subfolder relative to the TMX file

I assume that this used to work because the user (Brett) reported this as a bug to me, and the setup surely works in TilemapKit (after I fixed a bug). I further assume that Brett isn't using 0.13 because the tilecount attribute is absent from the TMX files.

Issue is based on this TilemapKit bug report: http://forum.tilemapkit.com/t/could-not-find-tileset-for-tile-gid-81/

Of the linked TMX files Test.tmx doesn't display anything in Tiled 0.13.0 (and 0.13.1).

I only get an empty map, see: http://forum.tilemapkit.com/uploads/default/optimized/1X/d2f2316dffdbfbb56d17c891c631c4e00894ccf5_1_531x500.png

The folder structure is as follows:

screen shot 2015-09-13 at 17 19 08

Note: I removed most PNG files just to keep the size of the screenshot in check, there are a lot more. Also, ignore Test-2.tmx.

@LearnCocos2D
Copy link
Author

FYI: testing on OSX 10.11 beta. If you can't reproduce let me know, I could re-check on 10.10 next week.

@bjorn bjorn added the bug Broken behavior. label Sep 13, 2015
@bjorn
Copy link
Member

bjorn commented Sep 13, 2015

The tile image references from the external tileset are actually wrong. These references should always be relative from the file that contains the reference, not from the map file. This makes sense, right? In your archive, the .tsx file is missing the ../ necessary to refer to the tiles correctly.

Tiled should not fail silently in this case, though. That's something I need to fix. The expected behavior in this case would be to report that it can't find the tile images.

@bjorn bjorn added this to the Tiled 1.0 milestone Sep 21, 2015
@bjorn
Copy link
Member

bjorn commented Oct 26, 2015

Now with change a80fca2, allowing the user to load the map anyway is the correct behavior. However, there should still be a warning shown to the user somehow to notify him that some images failed to load.

Also, it is not possible to correct the image references yet for external tilesets, but that's issue #242.

@bjorn
Copy link
Member

bjorn commented Nov 16, 2015

This problem is taken care of by the recent feedback added when opening a map with broken links. Now, a list of images that Tiled could not find is displayed above the map view.

@bjorn bjorn closed this as completed Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants