Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change duration of multiple frames in animation editor #1310

Closed
IMMZ opened this issue Jun 18, 2016 · 8 comments
Closed

Change duration of multiple frames in animation editor #1310

IMMZ opened this issue Jun 18, 2016 · 8 comments
Labels
feature It's a feature, not a bug.

Comments

@IMMZ
Copy link
Contributor

IMMZ commented Jun 18, 2016

Sometimes in animation editor you want to change all frames' duration to some other value than default one. Doing it every frame when add them (new frames) or after adding could be annoying enough. It would be good to select some of or all the frames and change this value to what you need one. Also it could be useful to consider the next features:

  • Add/Subtract[Multiply/Divide] selected durations by some number X.
  • Set random duration values in range [X-Y] for selected frames.

Used ver: Version 2016.05.17

@bjorn bjorn added the feature It's a feature, not a bug. label Jun 18, 2016
@bjorn bjorn changed the title [Feature request] Grouped duration change in animation editor. Change duration of multiple frames in animation editor Jun 18, 2016
@bjorn bjorn added the Bounty label Jul 10, 2016
@Alturos
Copy link
Contributor

Alturos commented Aug 7, 2016

Gonna have a crack at this. @bjorn: Thoughts on the bullet point items?

@bjorn
Copy link
Member

bjorn commented Aug 7, 2016

@Alturos Before starting to implement it, please consider how the UI should work for this and make a proposal. As for the bullet points, I don't personally see these actions as particular common and hence not very useful. However, what I do think is frequently needed is to change the speed / duration of the entire animation, adjusting each frame's duration accordingly (edit: actually this the multiply / divide durations action mentioned in the first bullet point). Another thing to improve here is that Tiled currently always uses 100ms as the default frame duration, but I think this should be configurable.

Also note that on the wip/tilesetdocument branch, tileset editing has been moved away from map editing. This affects also the Tile Animation Editor. The code has already changed there, so modifying it on master will create conflicts, and actually I'd like to turn this animation editor dialog into a view in the new Tileset editing mode.

So hmm, after all this I'm not sure if this is the best moment to tackle this particular issue. :/

@Alturos
Copy link
Contributor

Alturos commented Aug 7, 2016

Funny how that timing works. The proposal I'd come to (by getting it most of the way to done), was the simplest approach:

  • Add a toolbar button to the row above the listview
  • Enable/disable based on having a selection IN the listview
  • Hitting the button pops up a small dialog with a spinnerbox
  • Entering a value and hitting OK updates all the selected entries.

More or less end of list. At this rate, it looks like I could have that done by the end of the weekend. It's pretty light as features go, if you want to slip it in ahead of the tileset refactor. If not, also cool, I'll table it and look for something else to poke at.

@bjorn
Copy link
Member

bjorn commented Aug 7, 2016

Sounds fair. The other suggestions would of course be easy to add by means of a combo box in the dialog.

Actually it would be good to look at some other animation editors, to see how they work. I have personally never used an animation editor.

Alturos added a commit to Alturos/tiled that referenced this issue Aug 7, 2016
@Alturos
Copy link
Contributor

Alturos commented Aug 7, 2016

I may have jumped the gun on this one, but i was already 3/4's done, so figured I should just finish it. I think it's in line with the general UX theme of Tiled in general (or so my weary 4AM mind tells me). But it was light enough work that I didn't mind doing it, even if it's just throw away. 😄 😪

dorkster pushed a commit to dorkster/tiled that referenced this issue Jan 4, 2018
bjorn pushed a commit that referenced this issue Jan 12, 2018
)

Also, the default frame duration can now be changed and is persistent across sessions.

See issue #1310.

Closes #1330
@bjorn
Copy link
Member

bjorn commented Jan 12, 2018

@satu0king Would you like to work on the other features suggested by @IMMZ or shall I move those to a new issue, so that we can close this one for claiming the bounty?

@satu0king
Copy link
Contributor

I am not sure what bounty means. However, I think you can close the issue so as to avoid confusion. I am currently looking for issues that I can fix and get back to this eventually.

@bjorn
Copy link
Member

bjorn commented Jan 12, 2018

@satu0king There is a $15 bounty on this issue at https://www.bountysource.com/issues/35278005-change-duration-of-multiple-frames-in-animation-editor, which you can now claim. :-)

@bjorn bjorn closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature It's a feature, not a bug.
Projects
None yet
Development

No branches or pull requests

4 participants