Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwriting layernames when multiple tilemaps are open #1396

Closed
Clas1 opened this issue Nov 14, 2016 · 1 comment
Closed

overwriting layernames when multiple tilemaps are open #1396

Clas1 opened this issue Nov 14, 2016 · 1 comment
Assignees
Labels
bug Broken behavior. qt issue Qt related issue.

Comments

@Clas1
Copy link

Clas1 commented Nov 14, 2016

when a layer is selected in one map, doubleclicking a layer on another tilemaps leads to overwriting the layername in the first map

@bjorn bjorn added the bug Broken behavior. label Nov 14, 2016
@bjorn bjorn self-assigned this Nov 14, 2016
@bjorn bjorn closed this as completed in dcd95fe Nov 14, 2016
@bjorn
Copy link
Member

bjorn commented Nov 14, 2016

Nice catch. It appears to have been a bug in Qt since it only affected builds against Qt 5.7. For earlier Qt versions and for the current dev version of Qt, the editor was silently closed without committing a possible rename.

After my patch, if the text was changed before switching maps, then it will lead to a layer rename before the map is switched. I think this behavior is slightly better since it is the same when you focus something else, so I'll leave it be.

@bjorn bjorn added the qt issue Qt related issue. label Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior. qt issue Qt related issue.
Projects
None yet
Development

No branches or pull requests

2 participants