Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins Save #18

Closed
porfirioribeiro opened this issue May 23, 2011 · 1 comment
Closed

Plugins Save #18

porfirioribeiro opened this issue May 23, 2011 · 1 comment

Comments

@porfirioribeiro
Copy link
Contributor

Plugins in tiled using the MapWriterInterface appear on the Export dialog and not on Save dialog.

Maybe we could check if the plugin also includes a MapReaderInterface, if it does, its safe to save because you can also load, if not then its better to export, since the format wont be able to be read again!

stefanbeller added a commit to stefanbeller/tiled that referenced this issue Dec 21, 2011
* All Plugins, which can be read as well, can be used for
  saving as well.

* MapDocument class contains a new member (mWriterPluginFileName),
  which determines in which format the map should be saved.
  (It needs to be set accordingly, when opening a new File)

* The plugin manager has some more conversions.

* MapDocuments setFileName (only used by its saving function)
  is private now.

Closes mapeditor#18.
@porfirioribeiro
Copy link
Contributor Author

Instehead of having a MapReaderInterface and MapWriterInterface, tiled could have a MapSaveInterface (or better name) and MapExportInterface

Plugins using MapSaveInterface are plugins that support both saving and loading functions, that will appear on the Save and the Load dialogs and may be able to support more than one file type.
Plugins using MapExportInterface would just support save and appear on the Export dialog!

The Map class, should be able to know wish format it was loaded on so when we click save it would automatically use the plugin associated.

I think Tmx map support should follow the same rules and extend MapSaveInterface, so Tiled would not care about Tmx specifically as it does now, but just use it as any other Interface, it would just be the default one.

stefanbeller added a commit to stefanbeller/tiled that referenced this issue Sep 23, 2012
* All Plugins, which can be read as well, can be used for
  saving as well.

* MapDocument class contains a new member (mWriterPluginFileName),
  which determines in which format the map should be saved.
  (It needs to be set accordingly, when opening a new File)

* The plugin manager has some more conversions.

* MapDocuments setFileName (only used by its saving function)
  is private now.

Closes mapeditor#18.
@bjorn bjorn closed this as completed in ab6e112 Sep 25, 2012
bjorn added a commit that referenced this issue Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants