Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification when custom property of file type cannot be resolved #2080

Closed
Seanba opened this issue Mar 5, 2019 · 2 comments
Labels
Projects

Comments

@Seanba
Copy link
Contributor

@Seanba Seanba commented Mar 5, 2019

If a custom property references a file I would like some kind of notification if the user later moves or removes the file. I like the way Tiled handles this for when a tileset or texture dependency cannot be found so maybe custom properties can do that too?

Thanks as always. I remain a proud Tiled supporter. :)

@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Mar 6, 2019

That's definitely a good idea. I'll see if it can be integrated with the "broken links widget", though in general I think Tiled really needs a better way to show errors and warnings.

@bjorn bjorn added the feature label Mar 6, 2019
@bjorn bjorn added this to Tiled 1.3 (next feature release) in Roadmap May 10, 2019
@bjorn bjorn closed this in 4d5e049 Sep 3, 2019
Roadmap automation moved this from Tiled 1.3 (next feature release) to Recently Completed Sep 3, 2019
@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Sep 3, 2019

Well, that spawned quite a big amount of work, in a way.

Since I wasn't happy with the widget popping up when things fail to load, I'm trying to replace it. This ended up being the main thing I've been working on this month, but unfortunately it's not replaced yet.

However, there is now a new "Issues" view, and an Errors/Warnings counter in the status bar. With the above change, warnings are added to this view when there are custom file path properties pointing to files that do not exist. Double-clicking those warnings will in general select the relevant object, make sure the Properties view is visible and select the custom property. There are some edge-cases not implemented (like selection of terrains or having this work at all for properties on wang colors), but I don't expect many people to run into those.

image

Errors and warnings in the Issues view can also be reported from a script, where it is also possible to pass a callback function that is executed when the issue is activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Recently Completed
2 participants
You can’t perform that action at this time.