Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows extending of the polyline #1683

Merged
merged 12 commits into from Jan 16, 2018
Merged

Allows extending of the polyline #1683

merged 12 commits into from Jan 16, 2018

Commits on Aug 24, 2017

  1. Allows extending of the polyline

    Extending can be done from first node as well
    ketanhwr committed Aug 24, 2017
    Copy the full SHA
    471634d View commit details
    Browse the repository at this point in the history
  2. Review changes

    ketanhwr committed Aug 24, 2017
    Copy the full SHA
    284e302 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    679786b View commit details
    Browse the repository at this point in the history
  4. Review changes

    ketanhwr committed Aug 24, 2017
    Copy the full SHA
    8b0b680 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Fixed new polylines being drawn backwards after extending first

    The mExtendingFirst variable wasn't being reset.
    bjorn committed Sep 6, 2017
    Copy the full SHA
    f76249c View commit details
    Browse the repository at this point in the history
  2. Fixed extending polyline other than the one just created

    The shape and position were not being set on the overlay object when
    extending a polyline, so it only worked when those were still set from
    the last created polyline.
    bjorn committed Sep 6, 2017
    Copy the full SHA
    0009157 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Merge branch 'master' into ketanhwr-extending

    Conflicts:
    	src/tiled/editpolygontool.cpp
    bjorn committed Jan 12, 2018
    Copy the full SHA
    c436b53 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Enabled switching between tools using the ToolManager

    This way, the "Extend Polyline" action also works in the Tile Collision
    Editor.
    
    Also, it no longer appears in the Template view, because with the
    current implementation it can't work there since the "Insert Polyline"
    tool is not available there.
    bjorn committed Jan 16, 2018
    Copy the full SHA
    1633493 View commit details
    Browse the repository at this point in the history
  2. Fixed behavior when switching tools while extending a polyline

    Don't switch to EditPolygonTool when user selected another tool. This
    isn't what the user wants and it broke stuff.
    bjorn committed Jan 16, 2018
    Copy the full SHA
    49e6a40 View commit details
    Browse the repository at this point in the history
  3. Simplified code

    There appears to be no difference between finishing or canceling the
    extending of a polyline. In both cases we switch back to the "Edit
    Polygons" tool and in both cases we should also make sure the object we
    were extending is selected.
    
    There shouldn't actually be a reason to touch the selection at all when
    starting or stopping to extend a polyline, but currently the selection
    outline does not update as expected while extending a polyline.
    bjorn committed Jan 16, 2018
    Copy the full SHA
    f8bf814 View commit details
    Browse the repository at this point in the history
  4. Some further cleanups

    bjorn committed Jan 16, 2018
    Copy the full SHA
    6e2d1f7 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    046a950 View commit details
    Browse the repository at this point in the history