Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates docs #1703

Merged
merged 4 commits into from
Aug 25, 2017
Merged

Add templates docs #1703

merged 4 commits into from
Aug 25, 2017

Conversation

thabetx
Copy link
Contributor

@thabetx thabetx commented Aug 23, 2017

I reused some parts from the 1.1 alpha release post and reused the gifs from forum templates post.

I'm not sure if the reference part is clear enough, so I put an example template group.

Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good start and pushed some minor adjustments. Here are some additional comments.

The updates to the TMX Map Format page are not exactly following the structure of the document, but I understand it's a bit weird with the elements actually being in a separate file. I should probably adjust this document to mention external tileset files more explicitly as well. In any case, please don't forget to update the "Can contain" sections of the map element and to add this line to the templategroup and template elements.

===============

Any created object can be saved with all of its properties as a template, this
template can be used to create copies of the object on object layers. This can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's confusing to talk about "copies" here, since the template system specially avoids copying, which is one of the main advantages over using the already available copy-paste mechanism. Maybe we could make it:

Any created object can be saved as a template. These templates can then be instantiated elsewhere, as objects that inherit their properties.

Creating Templates
------------------

A template can be create by right clicking on any object in the map and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created*

template group to save the template to. If the object already has a name the
name field will be auto-filled with it.

Template groups can be created from the new template group button in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the button name should be capitalized "the New Template Group button".

name field will be auto-filled with it.

Template groups can be created from the new template group button in the
templates view or from the new template dialog.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization of named things: "Templates view or from the New Template dialog"

The templates View
------------------

Working with templates is done through the templates view. The templates view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More "Templates view"

-----------------

Selecting a template will load an editable preview in the templates view and
will load the template's properties into the properties view where they can be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "show" would be a better term than "load" here.

Also "the Properties view".

will load the template's properties into the properties view where they can be
edited.

All template instances are linked to the base template, so all edits will be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"linked to their template"? I'd prefer to avoid additional terms like "base template" when possible.

Detaching Template Instances
----------------------------

Detaching a template instance will disconnect it from the base template, so any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"disconnect it from its template"

@thabetx
Copy link
Contributor Author

thabetx commented Aug 25, 2017

I also feel that the format part is different from the rest of the document due to external referencing.

@bjorn bjorn merged commit 3d8354d into mapeditor:master Aug 25, 2017
@bjorn bjorn added the documentation Issue related to the Tiled Manual. label Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to the Tiled Manual.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants