Defaults filename to tileset name or image name

[killerasus]

Solves issue #1783

[bjorn]

First of all thanks for looking into addressing this issue!

Since it is a small patch and I found some issues, my suggested change is essentially a complete rewrite. Feel free to just make it though and I will merge this.

This was the first and so far only issue I've labeled as "good first issue" / "hacktoberfest", but feel free to look into anything else that seems doable!

[bjorn]

There are some problems with this patch as-is, mostly notably it removes "untitled.tsx" as a translatable string and always tries to translate the suggested file name (which will never work). You also only trim when checking for empty but not when actually using the tileset name, and the naming style of qName, tileSetName and cStrName is off with the rest of the code.

I would implement this as follows:

auto suggestedFileName = tilesetDocument->tileset()->name().trimmed();
if (suggestedFileName.isEmpty())
    suggestedFileName = QCoreApplication::translate("Tiled::Internal::MainWindow", "untitled"));
suggestedFileName.append(QLatin1String(".tsx"));

fileName = getSaveFileName(suggestedFileName);

The above unifies the adding of the extension and reduces the translatable string. The same thing could be done for "untitled.tmx", so there is one less string to translate.

[killerasus]

Hi @bjorn thanks for reviewing my pull request. Would this issue also consider the changes to "untitled.tmx" or should I implement it as another issue?

[killerasus]

This would also consider updating translation files to refer to untitled string instead of untitled.tsx and untitled.tmx, right?

[bjorn]

Would this issue also consider the changes to "untitled.tmx" or should I implement it as another issue?

Up to you, I'd be fine either way.

This would also consider updating translation files to refer to untitled string instead of untitled.tsx and untitled.tmx, right?

No, I'm only updating the translation files before a new feature release (usually about 2 weeks in advance). This should be sometime next month.

[bjorn]

Thanks!