Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to User in bottom status-bar regarding current active object Tools (not added for insert-template tool) #1862

Closed
wants to merge 1 commit into from

Conversation

keshav2010
Copy link
Contributor

Added information regarding object tools which is displayed in the bottom Status-bar,
all object tools covered except "Insert Template(V)" tool since i wasn't familiar with it enough.

@keshav2010 keshav2010 changed the title Suggestions to User in bottom status-bar regarding current active tool. Suggestions to User in bottom status-bar regarding current active object Tools (not added for insert-template tool) Jan 20, 2018
@bjorn
Copy link
Member

bjorn commented Jan 20, 2018

Please sort out the commits on your master branch. I think the easiest would be to make a new branch based on my master branch, and then cherry-pick change 7b9ddd1 on top of it (which seems to be the only relevant change). Then, force-push this new branch to your master on GitHub to update this pull request.

@keshav2010
Copy link
Contributor Author

Okay, even though I've never done it before, i followed these steps

  1. pulled your master into my master
  2. then made a new branch on my fork, named it as "temp" and switched to temp now
  3. now after switching to temp, i then executed following git command : git cherry-pick 7b9ddd1
  4. after this, i then executed following command : git push -f origin master while being inside "temp" branch,

i wonder if i did the right thing or not.

@bjorn
Copy link
Member

bjorn commented Jan 20, 2018

The last step was wrong. It force-pushed your local master to your master on GitHub, but the idea was to push the temp branch to master. Then the command should look like this:

git push -f origin temp:master

@keshav2010
Copy link
Contributor Author

keshav2010 commented Jan 20, 2018

Thank you very much, I've executed that command now, if anything is still wrong, do let me know.

@bjorn
Copy link
Member

bjorn commented Jan 20, 2018

@keshav2010 Alright, but it didn't do the trick. I think something went wrong in step 2 as well. You were supposed to make the new branch based on my master branch. It seems like you made it based on your master, so the cherry-pick just made the empty commit 11f35fb.

What did you call the remote pointing to my repository? Assuming it is called bjorn, you should do:

git checkout temp
git fetch bjorn
git reset --hard bjorn/master
git cherry-pick 7b9ddd1be47711e9c09b72dd640f6a1d7a9f0eb3
(maybe resolve conflicts)
git push -f origin temp:master

If everything goes alright, you should see the same changes in this PR, but only a single commit.

@keshav2010
Copy link
Contributor Author

keshav2010 commented Jan 21, 2018

Yea, much cleaner now. i never added a remote that pointed to your master. Though i got it now. Thank you 😄

@bjorn
Copy link
Member

bjorn commented Mar 18, 2018

@keshav2010 You need to create a separate branch for each pull request, to prevent your tileset view changes to show up here, as well as to prevent the status bar messages to become part of your tileset view work.

@keshav2010
Copy link
Contributor Author

I think I've to close this specific pull request and re-open a new one that instead of merging my fork's master with your master, will merge a new branch (namely statusBarSuggestionFeature branch) to your master.
meanwhile, for the future pull request, I will avoid merging my master directly and rather use the separate dedicated branch for each feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants