Holding shift with the eraser erases from all layers #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Not really performance sensitive in general, but I didn't like the O(M*N) complexity of the previous solution.
Previously you had to make sure to hold Shift when starting to erase. Also made it so that holding other modifiers like Alt and Ctrl don't prevent the Shift modifiers from working.
|
@aganm Thanks for this improvement! I made a few tweaks. The behavior changed so that other modifiers are now ignored and that you can toggle the strong mode also while erasing. Let me know if it all looks fine, if so we can merge this. |
|
Looks good to me! |
|
I found the reason for the It means, we should at least check that |
|
That should fix it #2904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement shift erase, I had to remove the check for Qt::NoModifier so I don't know if that's gonna collide with another command.