Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export additional algorithm modules in ES5 build #343

Closed
anoff opened this issue Jul 3, 2018 · 3 comments
Closed

Export additional algorithm modules in ES5 build #343

anoff opened this issue Jul 3, 2018 · 3 comments
Assignees
Milestone

Comments

@anoff
Copy link

anoff commented Jul 3, 2018

I am currently looking for a library to calculate a Hausdorff distance. I saw that you implemented it but it doesn't seem to be exported in the algorithm object that can be accessed after loading the module.

Would you be willing to approve a MR that exposes jsts.algorithm.DiscreteHausdorffDistance together with the other methods implemented but not exported to the library interface

import * as distance from './algorithm/distance_module'
import * as locate from './algorithm/locate'
import * as match from './algorithm/match'
@bjornharrtell
Copy link
Owner

Thanks, seems I forgot to re-export these modules for the ES5 build. Done with 52a29ed.

@bjornharrtell bjornharrtell added this to the 1.6.1 milestone Jul 3, 2018
@bjornharrtell bjornharrtell self-assigned this Jul 3, 2018
@sigeisler
Copy link

Hey, I'm currently encountering the same issue. Do you already know when you will release this fix?

@bjornharrtell
Copy link
Owner

Not sure when I can get time to do a release, sorry.

@bjornharrtell bjornharrtell changed the title DiscreteHausdorffDistance not exported/used? Export additional algorithm modules Jul 3, 2018
@bjornharrtell bjornharrtell changed the title Export additional algorithm modules Export additional algorithm modules in ES5 build Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants