Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JTS 1.17 #40

Closed
jiayuasu opened this issue Nov 23, 2020 · 4 comments
Closed

Support JTS 1.17 #40

jiayuasu opened this issue Nov 23, 2020 · 4 comments

Comments

@jiayuasu
Copy link

If use jts2geojson together with JTS 1.17+, the following exception will occur:

java.lang.NoSuchMethodError: org.locationtech.jts.geom.Polygon.getExteriorRing()Lorg/locationtech/jts/geom/LineString;
at org.wololo.jts2geojson.GeoJSONWriter.convert(GeoJSONWriter.java:79)
at org.wololo.jts2geojson.GeoJSONWriter.write(GeoJSONWriter.java:28)

Can you please support JTS 1.17+?

@jiayuasu
Copy link
Author

According to JTS 1.17 release notes: https://github.com/locationtech/jts/releases

This is due to an API change:

API Changes

Change Polygon getExteriorRing and getInteriorRingN accessors to return LinearRing.

  • This is a binary incompatible change to the method signature. Recompilation is necessary. No source code changes are required.

@lockwobr
Copy link
Contributor

Version 1.18 is out now... any updates on this? if its so simple, and i open a pr for it would get merged?

@jiayuasu
Copy link
Author

@lockwobr Yes, I also need this package to support 1.18 :-)

@lockwobr
Copy link
Contributor

just opened a pr to fix this issue.

#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants