Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with CommonMark v2 #78

Closed
michelmelo opened this issue Sep 8, 2021 · 3 comments · Fixed by #79
Closed

Fix compatibility with CommonMark v2 #78

michelmelo opened this issue Sep 8, 2021 · 3 comments · Fixed by #79

Comments

@michelmelo
Copy link

laravel 8.12
php 8
Your requirements could not be resolved to an installable set of packages.

Problem 1
- bjuppa/laravel-blog v1.8.0 requires illuminate/view 5.6.* || 5.7.* || 5.8.* || ^6.0 || ^7.0 -> found illuminate/view[v5.6.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev] but these were not loaded, likely because it conflicts with another require.
- bjuppa/laravel-blog[v1.8.1, ..., v1.8.2] require league/commonmark ^1.3 -> found league/commonmark[1.3.0, ..., 1.6.x-dev] but the package is fixed to 2.0.2 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
- Root composer.json requires bjuppa/laravel-blog ^1.8 -> satisfiable by bjuppa/laravel-blog[v1.8.0, v1.8.1, v1.8.2].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

@bjuppa
Copy link
Owner

bjuppa commented Sep 8, 2021

Thanks for the report! I wonder if Laravel has switched to require league/commonmark v2 since the last release of this package.

I'll investigate and see if it's possible to quickly release a new version.

@bjuppa
Copy link
Owner

bjuppa commented Sep 8, 2021

So... from laravel/framework#37954 we have the option to install either version 1.3 or 2 of commonmark.
This package is still on commonmark 1.3

@michelmelo you could try downgrading commonmark to 1.3 if you really want to install it now.

I'll go on to check the commonmark changelog to find out if there is anything holding us back from updating this package too.

@bjuppa bjuppa changed the title Your requirements could not be resolved to an installable set of packages. Fix compatibility with CommonMark v2 Sep 8, 2021
@bjuppa bjuppa closed this as completed in #79 Sep 8, 2021
@bjuppa
Copy link
Owner

bjuppa commented Sep 8, 2021

I've added compatibility with both CommonMark 1.x and 2.x and created a new release.

Hopefully this will solve your install conflict @michelmelo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants