-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow service setting externalName #339
Comments
Thanks for the effort, is there a way to test this implementation in my helm chart? It does not looks like you build beta/unstable charts? I also tried to add the template-service to my templates dir, but I was not able to fetch all variables from common template, which needs to be used in annotations and labels. Maybe you have an enable for that? |
I'm pushing out 3.3.0 right now and the required app-template (schema) updates after that, so you should be good to use that in a few minutes :) |
You didn't write a test for this externalName setting. Are you sure it was neigh to add it to the json file? service:
main:
primary: true
... snip ...
api-backend:
primary: false
controller: app
type: ExternalName
externalName: httpbin.org
ports:
http:
port: 80 returns the following spec spec:
type: ExternalName
ports:
- port: 80
targetPort: 80
protocol: TCP
name: http so without the |
Wh00ps... I interpreted the bug report as if it was only the schema preventing it from working. |
Thanks, it works now! 🥇 |
Details
Add support for service type: ExternalName:
Example:
Anything else you would like to add:
This is currently not possible, because of the
externalName
setting is not valid according to the common schema and would not be included in the templateAdditional Information:
Documentation here: https://kubernetes.io/docs/concepts/services-networking/service/#externalname
The text was updated successfully, but these errors were encountered: